Bug 176797

Summary: [PATCH] x11/fbpanel: Changed license, added OptionsNG, desktop entry, documentation, take maintainership
Product: Ports & Packages Reporter: nemysis <nemysis>
Component: Individual Port(s)Assignee: Beech Rintoul <beech>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
fbpanel-6.1_2.patch none

Description nemysis 2013-03-09 23:30:00 UTC
Makefile changed:

Port is now safe with NOPORTDOCS=yes in /etc/make.conf
+LICENSE=	MIT
+PORTDOCS=	CHANGELOG CREDITS NOTES README
+OPTIONS_DEFINE=	DOCS
+DESKTOP_ENTRIES=
+.include <bsd.port.options.mk>
+.if ${PORT_OPTIONS:MDOCS}

Changed and refined:
 post-install:
 pkg-plist

- Take maintainership

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
portlint -A
looks fine.

port test: clean
Comment 1 Beech Rintoul freebsd_committer 2013-03-10 04:19:50 UTC
Responsible Changed
From-To: freebsd-ports-bugs->beech

I'll take it
Comment 2 dfilter service freebsd_committer 2013-03-10 05:47:13 UTC
Author: beech
Date: Sun Mar 10 05:47:05 2013
New Revision: 313805
URL: http://svnweb.freebsd.org/changeset/ports/313805

Log:
  - Makefile changed:
    Port is now safe with NOPORTDOCS=yes in /etc/make.conf
    LICENSE= MIT
    PORTDOCS= CHANGELOG CREDITS NOTES README
    OPTIONS_DEFINE= DOCS
    DESKTOP_ENTRIES=
    .include <bsd.port.options.mk>
    .if ${PORT_OPTIONS:MDOCS}
  - Changed and refined:
    post-install:
    pkg-plist
  - Pass maintainership to submitter
  
  PR:		ports/176797
  Submitted by:	nemysis <nemysis@gmx.ch>

Modified:
  head/x11/fbpanel/Makefile   (contents, props changed)
  head/x11/fbpanel/pkg-plist   (contents, props changed)

Modified: head/x11/fbpanel/Makefile
==============================================================================
--- head/x11/fbpanel/Makefile	Sun Mar 10 04:31:12 2013	(r313804)
+++ head/x11/fbpanel/Makefile	Sun Mar 10 05:47:05 2013	(r313805)
@@ -3,15 +3,15 @@
 
 PORTNAME=	fbpanel
 PORTVERSION=	6.1
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	x11
 MASTER_SITES=	SF
 EXTRACT_SUFX=	.tbz2
 
-MAINTAINER=	ports@FreeBSD.org
+MAINTAINER=	nemysis@gmx.ch
 COMMENT=	Lightweight, NETWM compliant X11 desktop panel
 
-LICENSE=	GPLv2
+LICENSE=	MIT
 
 USE_BZIP2=	yes
 HAS_CONFIGURE=	yes
@@ -22,12 +22,34 @@ USE_PKGCONFIG=	build
 
 MAN1=		${PORTNAME}.1
 
+PORTDOCS=	CHANGELOG CREDITS NOTES README
+
+OPTIONS_DEFINE=	DOCS
+
+DESKTOP_ENTRIES="${PORTNAME}" "${PORTNAME} NETWM compliant X11 desktop panel" \
+		"${PREFIX}/share/pixmaps/${PORTNAME}.png" \
+		"${PORTNAME}" "System;" false
+
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MDOCS}
+PLIST_SUB+=	PORTDOCS=""
+.else
+PLIST_SUB+=	PORTDOCS="@comment "
+.endif
+
 post-patch:
 	@${REINPLACE_CMD} -e 's|bash|sh|' ${WRKSRC}/scripts/install.sh
 	@${REINPLACE_CMD} -e 's|@DATADIR@|${DATADIR}|' \
 		${WRKSRC}/data/man/${MAN1}.in
 
 post-install:
-	${INSTALL_MAN} ${WRKSRC}/data/man/${MAN1} ${MANPREFIX}/man/man1
+	${INSTALL_MAN} ${WRKSRC}/data/man/${MAN1} ${MAN1PREFIX}/man/man1/
+	${LN} -sf ${DATADIR}/images/logo.png ${PREFIX}/share/pixmaps/${PORTNAME}.png
+
+.if ${PORT_OPTIONS:MDOCS}
+	${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
+.endif
 
 .include <bsd.port.mk>

Modified: head/x11/fbpanel/pkg-plist
==============================================================================
--- head/x11/fbpanel/pkg-plist	Sun Mar 10 04:31:12 2013	(r313804)
+++ head/x11/fbpanel/pkg-plist	Sun Mar 10 05:47:05 2013	(r313805)
@@ -22,6 +22,10 @@ lib/fbpanel/tray.so
 lib/fbpanel/volume.so
 lib/fbpanel/wincmd.so
 libexec/fbpanel/make_profile
+%%PORTDOCS%%%%DOCSDIR%%/CHANGELOG
+%%PORTDOCS%%%%DOCSDIR%%/CREDITS
+%%PORTDOCS%%%%DOCSDIR%%/NOTES
+%%PORTDOCS%%%%DOCSDIR%%/README
 %%DATADIR%%/default
 %%DATADIR%%/images/battery_0.png
 %%DATADIR%%/images/battery_1.png
@@ -48,7 +52,9 @@ libexec/fbpanel/make_profile
 %%DATADIR%%/images/gnome-session-reboot.png
 %%DATADIR%%/images/logo.png
 %%DATADIR%%/pager
+share/pixmaps/fbpanel.png
 @dirrm %%DATADIR%%/images
 @dirrm %%DATADIR%%
+%%PORTDOCS%%@dirrm %%DOCSDIR%%
 @dirrm libexec/fbpanel
 @dirrm lib/fbpanel
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Beech Rintoul freebsd_committer 2013-03-10 05:47:35 UTC
State Changed
From-To: open->closed

Committed, Thanks!