Bug 177024

Summary: graphics/colord: [PATCH] typo in Makefile
Product: Ports & Packages Reporter: John Marino <draco>
Component: Individual Port(s)Assignee: Koop Mast <kwm>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description John Marino 2013-03-16 15:40:00 UTC
There is a typo in graphics/colord makefile regarding port options.  BMAKE will choke on it.

See patch for fix.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2013-03-16 15:40:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kwm

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Koop Mast freebsd_committer 2013-03-16 17:36:58 UTC
State Changed
From-To: open->closed

Committed, thanks! 
While the use of empty() isn't wrong I saw that I mismatched the ( and } in 
the orginal.
Comment 3 dfilter service freebsd_committer 2013-03-16 17:37:05 UTC
Author: kwm
Date: Sat Mar 16 17:36:53 2013
New Revision: 314380
URL: http://svnweb.freebsd.org/changeset/ports/314380

Log:
  Prevert ! instead of empty() and fix a typo.
  
  PR:		ports/177024
  Submitted by:	John Marino <draco@marino.st>

Modified:
  head/graphics/colord/Makefile

Modified: head/graphics/colord/Makefile
==============================================================================
--- head/graphics/colord/Makefile	Sat Mar 16 17:34:10 2013	(r314379)
+++ head/graphics/colord/Makefile	Sat Mar 16 17:36:53 2013	(r314380)
@@ -57,7 +57,7 @@ post-patch:
 		-e 's|-Wmissing-parameter-type||g' \
 		-e 's|LIBS="-lusb-1.0|LIBS="-lusb|g' \
 		${WRKSRC}/configure
-.if empty(PORT_OPTIONS:MMANPAGES}
+.if !${PORT_OPTIONS:MMANPAGES}
 	@${REINPLACE_CMD} -e "s|2MAN_TRUE=$$|2MAN_TRUE='#'|g ; \
 		s|2MAN_FALSE='#'|2MAN_FALSE=|g" ${WRKSRC}/configure
 .endif
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"