Bug 177201
| Summary: | french/aster: [PATCH] doesn't build in poudriere, several issues -- fixed | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John Marino <draco> | ||||||||
| Component: | Individual Port(s) | Assignee: | Thierry Thomas <thierry> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | ||||||||||
| Priority: | Normal | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
|
Description
John Marino
2013-03-21 15:10:00 UTC
Responsible Changed From-To: freebsd-ports-bugs->thierry Over to maintainer (via the GNATS Auto Assign Tool) State Changed From-To: open->feedback asteru is the main program (binary). If it has not been built on your environment, that reveals some errors (during compilation?). Could you please check your build log, and send it to me? Anyway, thanks for the other remarks! I was afraid that could be the case. I suspect the problem could be with libmetis -- it appears that at least the shared library is missing but aster seems to be detecting that and using the static library instead. In any case, here's the log: http://leaf.dragonflybsd.org/~marino/misc/aster-10.8.0.3.log If you spot the problem, do please let me know. I'll take another look at libmetis in the meantime. John On fri 22 mar 13 at 8:00:01 +0100, John Marino <draco@marino.st> wrote: > I was afraid that could be the case. > I suspect the problem could be with libmetis -- it appears that at least > the shared library is missing but aster seems to be detecting that and > using the static library instead. Just a note about that: the shared library is not really missing, it's just not installed. In math/metis-edf/Makefile there is: .if ${MACHINEARCH} == "i386" ${INSTALL_DATA} ${WRKSRC}/libmetis.so ${PREFIX}/lib ${INSTALL_PROGRAM} ${WRKSRC}/libmetis.so.1 ${PREFIX}/lib .endif and ldconfig is not run on non i386-platforms. Still working on it... -- Th. Thomas. On 4/3/2013 21:56, Thierry Thomas wrote: > Just a note about that: the shared library is not really missing, it's > just not installed. > > In math/metis-edf/Makefile there is: > > .if ${MACHINEARCH} == "i386" > ${INSTALL_DATA} ${WRKSRC}/libmetis.so ${PREFIX}/lib > ${INSTALL_PROGRAM} ${WRKSRC}/libmetis.so.1 ${PREFIX}/lib > .endif > > and ldconfig is not run on non i386-platforms. > > Still working on it... I saw that, but metis-edf was at fault anyway. Somebody decided to use the linker to create the shared library using --whole archive and this didn't work well at all. I changed it to make the compiler created the shared library. In my basic testing it worked, but I haven't tried to build aster on i386 yet to be sure. Patch attached. It applies over the other Makefile patch, not instead of it. John The previous patch for math/medis-edf used the wrong library name (libmetis.so instead of ../libmetis.so.1). The updated patch is attached and metis-edf now builds in poudriere on i386. Is there any heartburn with me committing the fix to math/metis-edf? french/aster is still not building the executable but fixing metis-edf is a step in the right direction. John Author: bf Date: Tue Aug 13 05:07:35 2013 New Revision: 324649 URL: http://svnweb.freebsd.org/changeset/ports/324649 Log: Use the compiler to assemble the shared libraries, in order to avoid linking problems PR: 177201 Submitted by: marino, thierry Modified: head/math/metis-edf/files/patch-Lib_Makefile (contents, props changed) Modified: head/math/metis-edf/files/patch-Lib_Makefile ============================================================================== --- head/math/metis-edf/files/patch-Lib_Makefile Tue Aug 13 04:25:49 2013 (r324648) +++ head/math/metis-edf/files/patch-Lib_Makefile Tue Aug 13 05:07:35 2013 (r324649) @@ -1,5 +1,5 @@ ---- Lib/Makefile.orig 2008-12-03 11:08:03.000000000 +0100 -+++ Lib/Makefile 2010-05-16 16:33:40.000000000 +0200 +--- Lib/Makefile.orig 2008-12-03 05:08:03.000000000 -0500 ++++ Lib/Makefile 2013-08-13 00:53:40.000000000 -0400 @@ -2,7 +2,7 @@ INCLUDES = -I. @@ -13,7 +13,7 @@ ../libmetis.a: $(OBJS) $(AR) $@ $(OBJS) -+ %%SHLIB%%$(LD) -Wl,-Bshareable -Wl,-o,../libmetis.so.1 -Wl,-x -Wl,-soname,libmetis.so.1 -Wl,--whole-archive ../libmetis.a -Wl,-no-whole-archive ++ %%SHLIB%%$(CC) -shared $(CFLAGS) $(LDFLAGS) -o ../libmetis.so.1 $(OBJS) -lm + %%SHLIB%%(cd .. && ln -sf libmetis.so.1 libmetis.so) clean: _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org" State Changed From-To: patched->closed The port has just been upgraded. It is still marked BROKEN, but this PR is no more applicable. Anyway, thanks for the report! State Changed From-To: feedback->patched math/metis-edf has been patched by bf. |
