Bug 17764

Summary: wrong percentage completed in bad144
Product: Base System Reporter: pccb <pccb>
Component: binAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 3.4-RELEASE   
Hardware: Any   
OS: Any   

Description pccb 2000-04-03 07:00:01 UTC
Running bad144 against a Maxtor 40.9GB Diamondmax Plus 40 harddisk using 'bad144 -v -s /dev/wd1s1c'
After running for one day, screen showing 30696123 of 80041059 blocks (4294967281%).
Comment 1 Sheldon Hearn 2000-04-03 13:06:58 UTC
On Sun, 02 Apr 2000 22:58:51 MST, pccb@yahoo.com wrote:

> >Synopsis:       wrong percentage completed in bad144

Just a quick note to let you know that you may need to wait for a
while before anyone looks into this, since bad144 doesn't exist in the
latest release of FreeBSD (4.0-RELEASE) nor in the development branch
(5.0-CURRENT).

Ciao,
Sheldon.
Comment 2 andrew 2000-04-07 22:16:51 UTC
On Sun, 2 Apr 2000 pccb@yahoo.com wrote:

> 
> >Number:         17764
> >Category:       bin
> >Synopsis:       wrong percentage completed in bad144
> >Confidential:   no
> >Severity:       non-critical
> >Priority:       low
> >Responsible:    freebsd-bugs

[snip]
> >Description:
> Running bad144 against a Maxtor 40.9GB Diamondmax Plus 40 harddisk using 
                                  ^^^^^^ You are lucky ;-)
> 'bad144 -v -s /dev/wd1s1c'
> After running for one day, screen showing 
> 30696123 of 80041059 blocks (4294967281%).

Please try following very simple patch ( I have revision 1.17.2.1
1999/08/29 of bad144.c). This should help, I suppose...

------begin diff------------
--- bad144.c.orig	Sat Apr  8 00:45:41 2000
+++ bad144.c	Sat Apr  8 01:01:03 2000
@@ -106,7 +106,7 @@
 	int f;
 	daddr_t bstart,bend;
 {
-	int curr_sec, n;
+	long long curr_sec, n;
 	int spc = dp->d_secpercyl;
 	int ss = dp->d_secsize;
 	int trk = dp->d_nsectors;
------end diff-------------

-- Andrew.
Comment 3 Poul-Henning Kamp freebsd_committer freebsd_triage 2000-06-01 23:41:41 UTC
State Changed
From-To: open->closed

Bad144 has been retired.  Besides you don't need to run bad144 on 
a disk like that.