Bug 177664

Summary: sysutils/ddrescue -- remove unnecessary lzip dependency
Product: Ports & Packages Reporter: Jeremy Chadwick <jdc>
Component: Individual Port(s)Assignee: Alex Kozlov <ak>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Jeremy Chadwick 2013-04-06 07:50:00 UTC 
	sysutils/ddrescue relies on lzip for what appears to be no legitimate
	reason -- the .tar.gz versions of ddrescue have been available on the
	official GNU mirrors for quite some time.  Here are 5 example mirrors
	that are reached when visiting http://ftpmirror.gnu.org/ddrescue/ --

	http://mirrors.ibiblio.org/gnu/ftp/gnu/ddrescue/
	http://mirrors.syringanetworks.net/gnu/ddrescue/
	http://mirror.nexcess.net/gnu/ddrescue/
	http://mirror.anl.gov/pub/gnu/ddrescue/
	http://mirror.nyi.net/GNU/gnu/ddrescue/

	Thus, remove the dependency and use our native tar/gz tools.  (Maybe
	one day libarchive will have lzip support natively...  :-) )

Fix: Apply below patch.  Patch will also be available at the following
	URL once I get a GNATS PR number:

	http://jdc.koitsu.org/freebsd/{prnum}/
How-To-Repeat: 	n/a
Comment 1 dfilter service freebsd_committer freebsd_triage 2013-04-19 03:59:17 UTC 
Author: ak
Date: Fri Apr 19 02:59:09 2013
New Revision: 316083
URL: http://svnweb.freebsd.org/changeset/ports/316083

Log:
  - Switch to tar.gz distfile to remove lzip dependency [1]
  - Convert Makefile headers to new style
  - Minor Makefile improvements
  
  PR:	ports/177664 [1]
  Submitted by:	Jeremy Chadwick <jdc@koitsu.org>
  Feature safe:	yes

Modified:
  head/sysutils/ddrescue/Makefile
  head/sysutils/ddrescue/distinfo   (contents, props changed)

Modified: head/sysutils/ddrescue/Makefile
==============================================================================
--- head/sysutils/ddrescue/Makefile	Fri Apr 19 02:54:09 2013	(r316082)
+++ head/sysutils/ddrescue/Makefile	Fri Apr 19 02:59:09 2013	(r316083)
@@ -1,15 +1,11 @@
-# New ports collection makefile for:	ddrescue
-# Date created:		16 August 2007
-# Whom:			Andrew Pantyukhin <infofarmer@FreeBSD.org>
-#
+# Created by: Andrew Pantyukhin <infofarmer@FreeBSD.org>
 # $FreeBSD$
-#
 
 PORTNAME=	ddrescue
 PORTVERSION=	1.16
+PORTREVISION=	1
 CATEGORIES=	sysutils
 MASTER_SITES=	GNU
-EXTRACT_SUFX=	.tar.lz
 
 MAINTAINER=	ports@FreeBSD.org
 COMMENT=	Data recovery tool
@@ -17,10 +13,6 @@ COMMENT=	Data recovery tool
 LICENSE=	GPLv3
 LICENSE_FILE=	${WRKSRC}/COPYING
 
-EXTRACT_DEPENDS=lzip:${PORTSDIR}/archivers/lzip
-
-EXTRACT_CMD=	${LOCALBASE}/bin/lzip
-
 OPTIONS_DEFINE=	DOCS
 
 HAS_CONFIGURE=	yes
@@ -40,13 +32,11 @@ do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/${i} ${PREFIX}/bin
 	${INSTALL_MAN} ${WRKSRC}/doc/${i}.1 ${MAN1PREFIX}/man/man1
 .endfor
-.for i in ddrescue
-	${INSTALL_DATA} ${WRKSRC}/doc/${i}.info ${PREFIX}/${INFO_PATH}
-.endfor
+	${INSTALL_DATA} ${WRKSRC}/doc/ddrescue.info ${PREFIX}/${INFO_PATH}
 .if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}
-.for file in ${PORTDOCS}
-	${INSTALL_DATA} ${WRKSRC}/${file} ${DOCSDIR}
+.for i in ${PORTDOCS}
+	${INSTALL_DATA} ${WRKSRC}/${i} ${DOCSDIR}
 .endfor
 .endif
 

Modified: head/sysutils/ddrescue/distinfo
==============================================================================
--- head/sysutils/ddrescue/distinfo	Fri Apr 19 02:54:09 2013	(r316082)
+++ head/sysutils/ddrescue/distinfo	Fri Apr 19 02:59:09 2013	(r316083)
@@ -1,2 +1,2 @@
-SHA256 (ddrescue-1.16.tar.lz) = 47ff778de4ff75a7e796c717e68fcef2000fe3ca25f824d3063259ebf930a65e
-SIZE (ddrescue-1.16.tar.lz) = 61763
+SHA256 (ddrescue-1.16.tar.gz) = 76b3f2e5fb0306d24f2632c3e168cccb73dc0a348e3a7089cd9230748ff23de6
+SIZE (ddrescue-1.16.tar.gz) = 104691
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 2 Alex Kozlov freebsd_committer freebsd_triage 2013-04-19 03:59:46 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ak

I'll take it.
Comment 3 Alex Kozlov freebsd_committer freebsd_triage 2013-04-19 03:59:55 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!