Bug 178198

Summary:	Fix port: ports-mgmt/pkg build fails with Werror
Product:	Ports & Packages	Reporter:	Chris Rees <crees>
Component:	Individual Port(s)	Assignee:	Port Management Team <portmgr>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Latest
Hardware:	Any
OS:	Any

Description Chris Rees freebsd_committer

2013-04-27 17:10:00 UTC

	On head with clang 3.2, pkg fails on style warnings;

	http://www.bayofrum.net/~crees/scratch/pkg-1.0.11.log

Fix: I tracked it down to bsd.sys.mk, which accepts NO_WERROR as a makevar.



-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.--gJjNQMT3F99FGPkaI50XDxkSCfBrDitHUic7L84lERznpP6K
Content-Type: text/plain; name="pkg-Werror.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="pkg-Werror.diff"

Index: Makefile
===================================================================
--- Makefile	(revision 316666)
+++ Makefile	(working copy)
@@ -22,7 +22,7 @@
 MANCOMPRESSED=	yes
 
 MAKE_ENV+=	WITHOUT_PROFILE=yes __MAKE_CONF=/dev/null SRCCONF=/dev/null \
-		PORTREVISION=${PORTREVISION}
+		NO_WERROR=yes PORTREVISION=${PORTREVISION}
 USE_STAGE=	yes
 # Use a submake as 'deinstall install' needs to reevaluate PKG_CMD
 # so that pkg-static is used from the wrkdir

Comment 1 Edwin Groothuis freebsd_committer

2013-04-27 17:10:08 UTC

Responsible Changed
From-To: freebsd-ports-bugs->portmgr

Over to maintainer (via the GNATS Auto Assign Tool)

Comment 2 Baptiste Daroussin freebsd_committer

2013-04-27 23:21:23 UTC

State Changed
From-To: open->closed

Tinderbox does not know how to use the ccache framework, the bug is from 
ccache in combinaison with clang, either export CCACHE_CPP2 or fix 
tinderbox to use the ccache framework from ports

Comment 3 Chris Rees freebsd_committer

2013-04-28 09:39:08 UTC

Objection!

It is still a bad idea to make everyone compile with -Werror; the most
important port in the tree should not break because the compiler gives
a warning.

Please consider disabling -Werror.

Chris

Comment 4 Chris Rees freebsd_committer

2013-04-28 12:08:33 UTC

Objection withdrawn after discussion on IRC.

Thanks for your time.

Chris