Bug 179047
| Summary: | [PATCH] net/nss_ldap: dpn't override ${PREFIX}/etc/nss_ldap.conf | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Anton Yuzhaninov <ayuzhaninov> | ||||
| Component: | Individual Port(s) | Assignee: | Andrej Zverev <az> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | mikeg | ||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Maintainer of net/nss_ldap,
Please note that PR ports/179047 has just been submitted.
If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.
The full text of the PR can be found at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/179047
--
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool) Responsible Changed From-To: freebsd-ports-bugs->az I'll take it. Author: az Date: Sat Jun 15 10:42:49 2013 New Revision: 320982 URL: http://svnweb.freebsd.org/changeset/ports/320982 Log: - Prevent situation which leads to overriding configuration file on reinstall. PR: ports/179047 Submitted by: Anton Yuzhaninov <ayuzhaninov@openstat.ru> Approved by: maintainer (timeout) Modified: head/net/nss_ldap/Makefile (contents, props changed) Modified: head/net/nss_ldap/Makefile ============================================================================== --- head/net/nss_ldap/Makefile Sat Jun 15 09:41:38 2013 (r320981) +++ head/net/nss_ldap/Makefile Sat Jun 15 10:42:49 2013 (r320982) @@ -75,9 +75,9 @@ do-install: ${INSTALL_MAN} ${WRKSRC}/${MAN5} ${MAN5PREFIX}/man/man5 post-install: -.if !exists(${PREFIX}/etc/nss_ldap.conf) - ${CP} -p ${PREFIX}/etc/nss_ldap.conf.sample ${PREFIX}/etc/nss_ldap.conf -.endif + @if [ ! -f ${PREFIX}/etc/nss_ldap.conf ]; then \ + ${CP} -pv ${PREFIX}/etc/nss_ldap.conf.sample ${PREFIX}/etc/nss_ldap.conf ; \ + fi .if !defined(PACKAGE_BUILDING) @${CAT} ${PKGMESSAGE} .endif _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org" State Changed From-To: feedback->closed Committed. Thanks! |
After upgrade net/nss_ldap my local /usr/local/etc/nss_ldap.conf was overridden by nss_ldap.conf.sample Port Makefile has !exists(${PREFIX}/etc/nss_ldap.conf) But this don't work, and should not work as need: variable ${PREFIX} expanded after !exists evaluted and cached. If you run make -d A install you will see: .... Searching for /etc/nss_ldap.conf...Looking for "/etc/nss_ldap.conf"...failed. Returning NULL .... Global:PREFIX = ${LOCALBASE} .... Port maintainer (mikeg@bsd-box.net) is cc'd. Generated with FreeBSD Port Tools 0.99_7 (mode: change, diff: ports) Fix: Just follow the Handbook: http://www.freebsd.org/doc/en/books/porters-handbook/plist-config.html How-To-Repeat: Edit /usr/local/etc/nss_ldap.conf update/install net/nss_ldap Local changes in /usr/local/etc/nss_ldap.conf will be lost.