Bug 179204

Summary: [patch] lang/gcc4[6789]: -Wcast-qual reports incorrect message
Product: Ports & Packages Reporter: pluknet <pluknet>
Component: Individual Port(s)Assignee: Gerald Pfeifer <gerald>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description pluknet 2013-06-02 16:30:00 UTC 
This is a request to apply patch from GNU GCC Bugzilla report 55383.

gcc erroneously reports incorrect message about casting volatile to non-volatile like this:
src/core/ngx_connection.c:988:29: error: cast discards '__attribute__((noreturn))' qualifier from pointer target type [-Werror=cast-qual]

The correct warning message:
src/core/ngx_connection.c:988:29: error: cast discards 'volatile' qualifier from pointer target type [-Werror=cast-qual]

The applied patch as from Bugzilla PR c/55383 fixes it.

Please note that at the time of filing this PR the patch has status NEW and is not committed to gcc tree.

Fix: Apply patch generated against ports svn tree.

Patch attached with submission follows:
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2013-06-05 03:25:15 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->gerald

Over to maintainer.
Comment 2 Gerald Pfeifer freebsd_committer freebsd_triage 2013-06-08 13:40:22 UTC 
State Changed
From-To: open->suspended

Thanks for the report.  If this were a mere backport of a patch 
accepted upstream, I would consider/apply it.  But accepting a 
patch into our ports that is not about FreeBSD-specifics and has 
not been accepted upstream is not a good idea and a long-term 
maintenance risk. 

I have added myself to the upstream report and will reach out to 
the patch author.
Comment 3 Gerald Pfeifer freebsd_committer freebsd_triage 2013-12-09 11:09:26 UTC 
State Changed
From-To: suspended->closed

I am sorry, I simply have not found the time (and may not anytime soon) 
to address this feature request. 

I will see whether I can at one point work on this upstream, and lang/gcc49 
or lang/gcc410 would then get this, but adding features not accepted upstream 
is beyond the realm of what we'd do in the FreeBSD Ports Collection.
Comment 4 Gerald Pfeifer freebsd_committer freebsd_triage 2014-03-18 22:09:50 UTC 
State Changed
From-To: closed->open

Things seem to be moving upstream.
Comment 5 dfilter service freebsd_committer freebsd_triage 2014-03-27 15:04:22 UTC 
Author: gerald
Date: Thu Mar 27 15:04:15 2014
New Revision: 349340
URL: http://svnweb.freebsd.org/changeset/ports/349340
QAT: https://qat.redports.org/buildarchive/r349340/

Log:
  Update to the 20140323 snapshot of GCC 4.9.0.
  
  Address a bug where -Wcast-qual would report an incorrect message. [1]
  
  PR:		179204 [1]

Modified:
  head/lang/gcc49/Makefile
  head/lang/gcc49/distinfo

Modified: head/lang/gcc49/Makefile
==============================================================================
--- head/lang/gcc49/Makefile	Thu Mar 27 14:37:43 2014	(r349339)
+++ head/lang/gcc49/Makefile	Thu Mar 27 15:04:15 2014	(r349340)
@@ -2,7 +2,7 @@
 # $FreeBSD$
 
 PORTNAME=	gcc49
-PORTVERSION=	4.9.0.20140316
+PORTVERSION=	4.9.0.20140323
 CATEGORIES=	lang java
 MASTER_SITES=	${MASTER_SITE_GCC}
 MASTER_SITE_SUBDIR=	snapshots/${DISTVERSION}

Modified: head/lang/gcc49/distinfo
==============================================================================
--- head/lang/gcc49/distinfo	Thu Mar 27 14:37:43 2014	(r349339)
+++ head/lang/gcc49/distinfo	Thu Mar 27 15:04:15 2014	(r349340)
@@ -1,2 +1,2 @@
-SHA256 (gcc-4.9-20140316.tar.bz2) = b1c62b70f98c551ce74ad8c6a5e7342fe9c899116f98aae2b9ca142a478a712c
-SIZE (gcc-4.9-20140316.tar.bz2) = 85573522
+SHA256 (gcc-4.9-20140323.tar.bz2) = 7af586f3477603f3235a6c9c67e4ed7456f0e4a9aaa5bf511dab088aafc94167
+SIZE (gcc-4.9-20140323.tar.bz2) = 85595760
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Gerald Pfeifer freebsd_committer freebsd_triage 2014-03-27 15:10:31 UTC 
State Changed
From-To: open->closed

This should be fixed in this port now.