Bug 17929

Summary:	pccardd uses /etc/pccard.conf.sample when man page says /etc/pccard.conf
Product:	Base System	Reporter:	byron <byron>
Component:	conf	Assignee:	Mitsuru IWASAKI <iwasaki>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	4.0-RELEASE
Hardware:	Any
OS:	Any

Description byron 2000-04-11 16:30:01 UTC

	The man page for pccard(8) says the default configuration file is
	/etc/pccard.conf, which is false.  /etc/defaults/rc.conf changes
	the config to be /etc/pccard.conf.sample, effectively changing the
	default for all practical use.

	As the file is marked .sample and there is no man page for
	pccard.conf.sample, I assumed it was the same as the
	/etc/ppp/ppp.shells.sample and similar files (such as those
	often placed into /usr/local/etc/rc.d/*.sample).  That is, the
	intension is that the file must be copied into place before it's
	usable; that it's just a sample file, not the real thing.

	I was wrong.

	/etc/defaults/rc.conf "magically" changes this perception, breaking
	the .sample convention used throughout the system, and causing a
	great amount of confusion when none of my changes in
	/etc/pccard.conf had any effect.

	This wasn't the case in earlier releases and it shouldn't be the
	case now, IMHO.

Fix: 

Set the pccard_conf variable in /etc/defaults/rc.conf to point to
	/etc/pccard.conf.  Either copy or better yet move
	/etc/pccard.conf.sample to /etc/pccard.conf.
How-To-Repeat: 
	Copy /etc/pccard.conf.sample to /etc/pccard.conf as one would expect
	to be the way to do things.  Change something in /etc/pccard.conf
	and watch pccardd simply ignore your changes.

Comment 1 brooks 2000-04-11 18:15:51 UTC

On Tue, Apr 11, 2000 at 08:29:22AM -0700, byron@omix.com wrote:
> >Description:
> 
> 	The man page for pccard(8) says the default configuration file is
> 	/etc/pccard.conf, which is false.  /etc/defaults/rc.conf changes
> 	the config to be /etc/pccard.conf.sample, effectively changing the
> 	default for all practical use.
> 
> 	As the file is marked .sample and there is no man page for
> 	pccard.conf.sample, I assumed it was the same as the
> 	/etc/ppp/ppp.shells.sample and similar files (such as those
> 	often placed into /usr/local/etc/rc.d/*.sample).  That is, the
> 	intension is that the file must be copied into place before it's
> 	usable; that it's just a sample file, not the real thing.
> 
> 	I was wrong.
> 
> 	/etc/defaults/rc.conf "magically" changes this perception, breaking
> 	the .sample convention used throughout the system, and causing a
> 	great amount of confusion when none of my changes in
> 	/etc/pccard.conf had any effect.
> 
> 	This wasn't the case in earlier releases and it shouldn't be the
> 	case now, IMHO.

This PR is obsolete.  The new configuration method in -current makes the
system read /etc/defaults/pccard.conf which in turn read
/etc/pccard.conf to provide override support.  This is the solution
which should be adopted in 4.0.

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.

Comment 2 byron 2000-04-11 18:23:33 UTC

Brooks Davis <brooks@one-eyed-alien.net> wrote:
> On Tue, Apr 11, 2000 at 08:29:22AM -0700, byron@omix.com wrote:
> > 	The man page for pccard(8) says the default configuration file is
> > 	/etc/pccard.conf, which is false.  /etc/defaults/rc.conf changes
> > 	the config to be /etc/pccard.conf.sample, effectively changing the
> > 	default for all practical use.
	>snip<
> This PR is obsolete.  The new configuration method in -current makes the
> system read /etc/defaults/pccard.conf which in turn read
> /etc/pccard.conf to provide override support.  This is the solution
> which should be adopted in 4.0.

	How recently was this done?  4.0-RELEASE isn't all that old.  Has
	the above been moved to -stable?

-Byron

Comment 3 brooks 2000-04-11 18:39:57 UTC

On Tue, Apr 11, 2000 at 10:23:33AM -0700, Byron Brummer wrote:
> Brooks Davis <brooks@one-eyed-alien.net> wrote:
> > On Tue, Apr 11, 2000 at 08:29:22AM -0700, byron@omix.com wrote:
> > > 	The man page for pccard(8) says the default configuration file is
> > > 	/etc/pccard.conf, which is false.  /etc/defaults/rc.conf changes
> > > 	the config to be /etc/pccard.conf.sample, effectively changing the
> > > 	default for all practical use.
> 	>snip<
> > This PR is obsolete.  The new configuration method in -current makes the
> > system read /etc/defaults/pccard.conf which in turn read
> > /etc/pccard.conf to provide override support.  This is the solution
> > which should be adopted in 4.0.
> 
> 	How recently was this done?  4.0-RELEASE isn't all that old.  Has
> 	the above been moved to -stable?

It was done on April 3.  I suspect it will be merged, but it hasn't been
yet.  I've CCed the PC Card maintainers for a definitive answer.

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.

Comment 4 Warner Losh 2000-04-11 18:41:47 UTC

In message <20000411103957.B20344@orion.ac.hmc.edu> Brooks Davis writes:
: It was done on April 3.  I suspect it will be merged, but it hasn't been
: yet.  I've CCed the PC Card maintainers for a definitive answer.

I think that the best thing to do is wait for iwasaki-san to clear his
queue of patches, then do one mega back commit all at once.

Warner

Comment 5 Joseph Koshy freebsd_committer

2000-04-14 05:59:06 UTC

Responsible Changed
From-To: freebsd-bugs->iwasaki

Over to maintainer.

Comment 6 Mitsuru IWASAKI freebsd_committer

2000-04-15 12:20:04 UTC

State Changed
From-To: open->closed

The pccardd default config file is changed to /etc/defaults/pccard.conf. 
/etc/pccard.conf.sample is no longer used in -CURRENT/STABLE. 

Thanks!