Bug 179497

Summary: [patch] service.8 add csh completion example
Product: Documentation Reporter: Olli Hauer <ohauer>
Component: Manual PagesAssignee: Daniel Ebdrup Jensen <debdrup>
Status: Closed FIXED    
Severity: Affects Only Me CC: debdrup, doc
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
service_8.diff none

Description Olli Hauer freebsd_committer freebsd_triage 2013-06-11 21:50:00 UTC
service(8) has an example for bash completion, however bash is third party
and in /usr/share/examples/csh/dot.cshrc is a working example for csh.

Extend the service(8) manpage with the completion ripped from dot.cshrc

How-To-Repeat: avoid bash and use csh as shell ;)
Comment 1 Daniel Ebdrup Jensen freebsd_committer freebsd_triage 2021-01-16 20:53:25 UTC
I'll take this.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-01-16 21:06:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=c6a112cf84d2bf55101c0fb61c4fd1e3cf5d3cc8

commit c6a112cf84d2bf55101c0fb61c4fd1e3cf5d3cc8
Author:     Daniel Ebdrup Jensen <debdrup@FreeBSD.org>
AuthorDate: 2021-01-16 20:55:20 +0000
Commit:     Daniel Ebdrup Jensen <debdrup@FreeBSD.org>
CommitDate: 2021-01-16 21:05:29 +0000

    service.8: Provide example for adding completions to (t)csh

    service(8) has an example for bash completion, however bash is third
    party and in /usr/share/examples/csh/dot.cshrc is a working example for
    csh.

    Since I use (t)csh, I've tested it, and it works for me.

    PR:             179497
    Submitted by:   ohauer@

    Reviewed by:    kp (tentatively)
    Differential Revision:  https://reviews.freebsd.org/D28197

 usr.sbin/service/service.8 | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Comment 3 Daniel Ebdrup Jensen freebsd_committer freebsd_triage 2021-01-16 21:31:38 UTC
This has been fixed (although I need to fix my use of out-dated macros, but I won't spam the bug tracker with that).

Thank you, Olli. :)