Bug 179666

Summary: [PATCH] Fix graphics/graphviz with WITH_PERL
Product: Ports & Packages Reporter: geraud
Component: Individual Port(s)Assignee: Dirk Meyer <dinoex>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description geraud 2013-06-18 01:50:00 UTC 
Long story short : the config/config_perl.pl file has changed significantly in the tarball and while the patch applies, the resulting file fails to run correctly under a recent perl (at least on 5.14). As a result the Perl bindings are not built (let alone packaged) when the PERL option is active.

The port will build fine but `make package` will report the missing files and fail.

Fix: See attached patch (while there, I made some slight changes to silence a warning about future deprecation).

Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/graphics/graphviz; make 
[x] PERL
make package
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-18 01:50:10 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-06-24 19:58:08 UTC 
Author: dinoex
Date: Mon Jun 24 18:57:56 2013
New Revision: 321706
URL: http://svnweb.freebsd.org/changeset/ports/321706

Log:
  - fix option PERL
  PR:		179666
  Submitted by:	Geraud CONTINSOUZAS

Modified:
  head/graphics/graphviz/files/patch-config_perl.pl

Modified: head/graphics/graphviz/files/patch-config_perl.pl
==============================================================================
--- head/graphics/graphviz/files/patch-config_perl.pl	Mon Jun 24 18:54:47 2013	(r321705)
+++ head/graphics/graphviz/files/patch-config_perl.pl	Mon Jun 24 18:57:56 2013	(r321706)
@@ -1,9 +1,14 @@
---- config/config_perl.pl.orig	2008-07-14 14:54:04.000000000 +0200
-+++ config/config_perl.pl	2009-03-15 11:08:29.000000000 +0100
-@@ -11,5 +11,5 @@
+--- config/config_perl.pl.orig	2013-02-15 00:27:39.000000000 +1100
++++ config/config_perl.pl	2013-06-18 11:18:34.000000000 +1100
+@@ -11,10 +11,9 @@
  	print "-I$archlib/CORE";
  }
  if ($ARGV[0] eq "PERL_INSTALL_DIR") {
--	print "$Config{vendorarch}"
-+	print "$Config{sitearch}"
- }
+-
+ 	my $d;
+ 
+-	foreach $d qw(installvendorarch vendorarch installsitearch sitearch) {
++	foreach $d ( qw(installvendorarch vendorarch installsitearch sitearch) ) {
+ 		if (exists($Config{$d}) and defined($Config{$d}) and
+ 			($Config{$d} ne '') ) {
+ 			print "$Config{$d}";
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2013-06-24 21:20:28 UTC 
State Changed
From-To: open->closed


committed, thanks.