Summary: | [PATCH] graphics/pngcrush: failed checksum again (less 1 week after fixing it) | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | John Marino <draco> | ||||
Component: | Individual Port(s) | Assignee: | Joseph S. Atkinson <jsa> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | ||||||
Priority: | Normal | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
John Marino
2013-06-21 00:40:00 UTC
Responsible Changed From-To: freebsd-bugs->freebsd-ports-bugs ports PR. Responsible Changed From-To: freebsd-ports-bugs->jsa Over to maintainer (via the GNATS Auto Assign Tool) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 The actual solution here is to add the archive path as the 2nd master site. I was going to do this previously and will address it by or over the weekend. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRw+3rAAoJEMyd/IQhqnsGYzAH/2axDImGaULqniS7XiQG48A9 HgoHcRL1nfNEMuROHPOJEL3ZXjp92li+7B8NSkdbkWd7ugK7VBXrDAXFTELRWpyz wA9rn1DXDUaw7xzg5+RiSyVaHE74bKABvV6KOE5H/1fcR0Wd6ydO891/lk8pot5p Ps6rdookWMuu9RVSs1Lu3delkkenP1jk+DbTFOJboDAeJohdDLKZizTjbtZdJ8aV 9IRAAio+rq3vLsSiOSgCFgNM3O7FRv+V9DSMMyBxYUaqLiVglQeSK/qgaGlAi9Os 4ttfGr8hfDN2W8lfhUFPsE1IZoCwpYBG706cz7eNxVss1hyt+6V5DlZr8bh2DRk= =ZXG6 -----END PGP SIGNATURE----- > it seems pngcrush is very aggressive about moving "old" versions to the a=
rchives. The master_sites was just updated a week ago, and it's already ob=
solete. Maybe it should just be left to the archives. The attached patch =
at least restores the build (again).
Hello,
Why you didn't send an update to port instead of unbreaking fetch?
But thanks for the report anyway, I'll create a separate PR for
updating pngcrush.
On 6/21/2013 08:25, Sayetsky Anton wrote:
>> it seems pngcrush is very aggressive about moving "old" versions to the archives. The master_sites was just updated a week ago, and it's already obsolete. Maybe it should just be left to the archives. The attached patch at least restores the build (again).
> Hello,
> Why you didn't send an update to port instead of unbreaking fetch?
> But thanks for the report anyway, I'll create a separate PR for
> updating pngcrush.
If you'll query the PR system, you'll see that I submitted around 60 PRs
in the last couple of days. I simply don't have time to fix every
problem I find, which in order to do correctly includes testing on
redports. I've found other problems where I didn't even submit a PR.
I'm finding lots of problems although a few have been false alerts.
I consider the PR system a way to "alert" the maintainer (or ports@)
that there's a problem with the port, and that an alert without a
solution is more than acceptable.
John
I have a patch to work around the randomness of updates that should at least prevent it from breaking. I will try to get this done and off to someone who can commit in my stead. It's been a few weeks since jsa said he was working on a patch. I am planning to add the archive to the list of master sites in order to close out this PR, unless said patch is imminent. Thanks, John Author: marino Date: Tue Sep 10 20:36:27 2013 New Revision: 326931 URL: http://svnweb.freebsd.org/changeset/ports/326931 Log: graphics/pngcrush: Add archive to MASTER_SITES to unbreak fetch The distfile is frequently archived by upstream. The previous unbreak fetch effort lasted less than a week! By adding the archive location to the MASTER_SITES definition, we can make this port function longer. PR: ports/179795 Approved by: maintainer (timeout) Modified: head/graphics/pngcrush/Makefile Modified: head/graphics/pngcrush/Makefile ============================================================================== --- head/graphics/pngcrush/Makefile Tue Sep 10 20:28:30 2013 (r326930) +++ head/graphics/pngcrush/Makefile Tue Sep 10 20:36:27 2013 (r326931) @@ -4,7 +4,8 @@ PORTNAME= pngcrush PORTVERSION= 1.7.59 CATEGORIES= graphics -MASTER_SITES= SF/pmt/${PORTNAME}/${PORTVERSION}/ +MASTER_SITES= SF/pmt/${PORTNAME}/${PORTVERSION}/ \ + SF/pmt/${PORTNAME}/old-versions/1.7/${PORTVERSION}/ DISTNAME= ${PORTNAME}-${PORTVERSION}-nolib MAINTAINER= jsa@FreeBSD.org _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org" State Changed From-To: open->closed Committed, with minor changes. Thanks! |