Bug 179806

Summary: databases/mysql51-client: Remove unneeded patch that breaks build
Product: Ports & Packages Reporter: John Marino <draco>
Component: Individual Port(s)Assignee: Alex Dupre <ale>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch-include_my_tcpd.h
none
my_tcpd.h none

Description John Marino 2013-06-21 11:00:00 UTC 
The patch "patch-include_my_tcpd.h" is no longer needed by mysql51.  In fact, it seems that the previous version didn't need it either.

It doesn't apply anymore.
The functionality it wants to add is now present in include/my_tcpd.h

Removing the patch completely allows mysql51 to build again.

Fix: 

verify that patch-include_my_tcpd.h no longer applies with "make patch", then remove it and build mysql51-client.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-21 11:29:24 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ale

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 freebsd.contact 2013-07-18 09:16:30 UTC 
ping.  This PR has been around 4 weeks.
Do you want me to take over responsibility for PR and commit the fix?
John
Comment 3 John Marino 2013-07-22 16:18:37 UTC 
As a follow-up to a private mail:

As I said in the "Description", patch-include_my_tcpd.h is obsolete.  It
doesn't apply on DragonFly dports, failing with an "unordered hunks"
message.  It shouldn't apply on FreeBSD either, but no error is seen.

I have attached two files to this post:
1) The original file obtained from "make extract"
2) The patch

A quick inspect should confirm these two things:
1) The patch shouldn't apply due to major differences
2) The patch is no longer needed.  The functionality that the patch
tries to add is already included.

One theory is that the patch is failing silently on FreeBSD and the file
is never changed, and it builds normally.  I'd need to boot up a FreeBSD
box to test this theory.

I encourage Alex to review both of these files and independently
confirm.  And if he agrees, remove the patch from mysql51-server/files.
 Mysql51-client should still build.

Regards,
John
Comment 4 Alex Dupre freebsd_committer freebsd_triage 2013-08-12 14:08:16 UTC 
State Changed
From-To: open->closed

Probably you are not aware that we are patching FreeBSD's (and not MySQL) tcpd.h.