Bug 180579

Summary:	committer's guide incomplete on ports removal
Product:	Documentation	Reporter:	Matthias Andree <mandree>
Component:	Books & Articles	Assignee:	Warren Block <wblock>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Latest
Hardware:	Any
OS:	Any

Description Matthias Andree freebsd_committer

2013-07-15 19:00:00 UTC

The Committer's Guide is incomplete with respect to removing ports.
I am looking at revision 42226 as obtained from 
<http://www.freebsd.org/doc/en/articles/committers-guide/article.html#idp74042160>

We used to use CVS, and hence section 13.2.1 "How do I remove an
existing port?" mentions, in a box:

* Then, remove the port:

1. Remove the port's files via svn remove.

2. Remove the SUBDIR listing of the port in the parent directory Makefile.

3. Add an entry to ports/MOVED.

4. Remove the port from ports/LEGAL if it is there.


This is incomplete in that step 1 mentions "remove the port's files".
This used to suffice because CVS only tracked files, and the client was
responsible for removing directories when the last contained file had
been removed.

With SVN, directories are tracked in addition to files.

I propose to change 1. to read:

Remove the port's files and its directory via svn remove.

Fix: 

Change bullet 1 text from

    Remove the port's files via svn remove.

to

    Remove the port's files and its directory via svn remove.

Comment 1 Warren Block freebsd_committer

2013-07-15 19:22:20 UTC

Responsible Changed
From-To: freebsd-doc->wblock

Take.

Comment 2 dfilter service freebsd_committer

2013-07-15 19:35:31 UTC

Author: wblock
Date: Mon Jul 15 18:35:24 2013
New Revision: 42286
URL: http://svnweb.freebsd.org/changeset/doc/42286

Log:
  Removing a port also requires removing the directory.
  
  PR:		docs/180579
  Submitted by:	Matthias Andree <mandree@FreeBSD.org>

Modified:
  head/en_US.ISO8859-1/articles/committers-guide/article.xml

Modified: head/en_US.ISO8859-1/articles/committers-guide/article.xml
==============================================================================
--- head/en_US.ISO8859-1/articles/committers-guide/article.xml	Mon Jul 15 15:23:13 2013	(r42285)
+++ head/en_US.ISO8859-1/articles/committers-guide/article.xml	Mon Jul 15 18:35:24 2013	(r42286)
@@ -3529,7 +3529,7 @@ ControlPersist yes</screen>
 
 		<procedure>
 		  <step>
-		    <para>Remove the port's files via
+		    <para>Remove the port's files and directory with
 		      <command>svn remove</command>.</para>
 		  </step>
 
_______________________________________________
svn-doc-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-doc-all
To unsubscribe, send any mail to "svn-doc-all-unsubscribe@freebsd.org"

Comment 3 Warren Block freebsd_committer

2013-07-15 19:35:54 UTC

State Changed
From-To: open->closed

Correction made, thanks!