Bug 180619

Summary: [patch] ftp/wget:: stealth dependency on misc/e2fsprogs-libuuid
Product: Ports & Packages Reporter: Panagiotis Christias <p.christias>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me CC: amdmi3, brnrd, cs
Priority: Normal Keywords: patch-ready
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
Update patch for wget 1.16 none

Description Panagiotis Christias 2013-07-17 23:40:00 UTC
Ftp/wget configure script is looking for uuid/uuid.h and if found then wget gets linked lib/libuuid.so resulting a stealth dependency against misc/e2fsprogs-libuuid that carries those files.

If misc/e2fsprogs-libuuid get uninstalled at some point, ftp/wget starts complaining about missing shared library.

Fix: Ftp/wget carries its own UUID generating function that is used by default (see warc_uuid_str() in src/warc.c), so there is no real reason(?) to be linked against libuuid.

The attached patch removes the uuid.h check from the configure script.


Patch attached with submission follows:
How-To-Repeat: % cd /usr/ports/misc/e2fsprogs-libuuid
% make install
[...]
% cd /usr/ports/ftp/wget
% make install
[...]
% ldd /usr/local/bin/wget 
/usr/local/bin/wget:
        libiconv.so.3 => /usr/local/lib/libiconv.so.3 (0x800887000)
        libssl.so.6 => /usr/lib/libssl.so.6 (0x800b84000)
        libcrypto.so.6 => /lib/libcrypto.so.6 (0x800dd9000)
        libz.so.6 => /lib/libz.so.6 (0x80117a000)
        libidn.so.17 => /usr/local/lib/libidn.so.17 (0x80138e000)
        libuuid.so.1 => /usr/local/lib/libuuid.so.1 (0x8015c0000)
        libc.so.7 => /lib/libc.so.7 (0x8017c4000)
% cd /usr/ports/misc/e2fsprogs-libuuid
% make deinstall
[...]
% wget
Shared object "libuuid.so.1" not found, required by "wget"
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-17 23:40:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->vd

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Carlo Strub freebsd_committer freebsd_triage 2014-09-14 10:38:51 UTC
Is this PR still relevant?
Comment 3 Bernard Spil freebsd_committer freebsd_triage 2014-11-10 10:41:46 UTC
Created attachment 149246 [details]
Update patch for wget 1.16

Yes, this is still necessary
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2014-11-20 16:01:18 UTC
+1. Just ran into this problem.
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-11 10:51:18 UTC
Maintainer timeout.
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-12-11 13:04:56 UTC
A commit references this bug:

Author: amdmi3
Date: Thu Dec 11 13:03:55 UTC 2014
New revision: 374529
URL: https://svnweb.freebsd.org/changeset/ports/374529

Log:
  - Remove hidden dependency on libuuid.so from misc/e2fsprogs-libuuid

  While here:
  - Simplify MASTER_SITES
  - Clarify LICENSE and add LICENSE_FILE

  PR:		180619
  Submitted by:	p.christias@noc.ntua.gr
  Approved by:	maintainer timeout (vd, 16 months)

Changes:
  head/ftp/wget/Makefile