Bug 181291

Comment 1 Edwin Groothuis 2013-08-14 15:00:08 UTC

State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)

Comment 2 Edwin Groothuis 2013-08-14 15:00:08 UTC

Maintainer of mail/postgrey,

Please note that PR ports/181291 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/181291

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org

Yahuhiro,

Thank you for the patch.  This should be fixed upstream; but I'm not 
opposed to a temporary local patch.

I am out of town the rest of August.  I will spin up a remote VM and 
test out the patch later this week.  In the meantime, would you submit 
this to David's github as a follow-up to the open issue?

Regards,

Darren Pilgrim

Comment 4 Yasuhiro Kimura 2013-08-17 11:47:32 UTC

Hello Darren,

From: Darren Pilgrim <ports.maintainer@evilphi.com>
Subject: Re: ports/181291: [PATCH] mail/postgrey: make postgrey work with perl 5.18
Date: Wed, 14 Aug 2013 13:27:24 -0400

> In the meantime, would you submit this to David's github as a
> follow-up to the open issue?
>
> Regards,

I submitted the patch as following:

https://github.com/schweikert/postgrey/issues/3#issuecomment-22809331

Just FYI.

The patch works fine.  Please commit as submitted.  Thanks!

Comment 6 Yasuhiro Kimura 2013-10-10 12:11:15 UTC

From: Yasuhiro KIMURA <yasu@utahime.org>
Subject: Re: ports/181291: [PATCH] mail/postgrey: make postgrey work with perl 5.18
Date: Sat, 17 Aug 2013 19:47:32 +0900 (JST)

>> In the meantime, would you submit this to David's github as a
>> follow-up to the open issue?
> 
> I submitted the patch as following:
> https://github.com/schweikert/postgrey/issues/3#issuecomment-22809331

The patch is accepted by upstream.

https://github.com/schweikert/postgrey/pull/4

Just another FYI.

Comment 7 Po-Chuan Hsieh 2013-10-19 21:01:39 UTC

Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

I'll take it.

Comment 8 dfilter service 2013-10-19 21:03:59 UTC

Author: sunpoet
Date: Sat Oct 19 20:03:52 2013
New Revision: 330931
URL: http://svnweb.freebsd.org/changeset/ports/330931

Log:
  - Make postgrey work with Perl 5.18
  - Bump PORTREVISION for package change
  
  PR:		ports/181291
  Reference:	https://github.com/schweikert/postgrey/commit/569dd044840a075127ddcf9d92c7791677d118e2
  Submitted by:	Yasuhiro KIMURA <yasu@utahime.org>
  Approved by:	Darren Pilgrim <ports.maintainer@evilphi.com> (maintainer)

Added:
  head/mail/postgrey/files/patch-postgrey   (contents, props changed)
Modified:
  head/mail/postgrey/Makefile

Modified: head/mail/postgrey/Makefile
==============================================================================
--- head/mail/postgrey/Makefile	Sat Oct 19 19:51:06 2013	(r330930)
+++ head/mail/postgrey/Makefile	Sat Oct 19 20:03:52 2013	(r330931)
@@ -3,7 +3,7 @@
 
 PORTNAME=	postgrey
 PORTVERSION=	1.34
-PORTREVISION=	6
+PORTREVISION=	7
 CATEGORIES=	mail
 MASTER_SITES=	http://postgrey.schweikert.ch/pub/ \
 		http://postgrey.schweikert.ch/pub/old/

Added: head/mail/postgrey/files/patch-postgrey
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/mail/postgrey/files/patch-postgrey	Sat Oct 19 20:03:52 2013	(r330931)
@@ -0,0 +1,19 @@
+--- postgrey.orig	2011-05-05 04:54:15.000000000 +0800
++++ postgrey	2013-10-20 01:07:50.744835568 +0800
+@@ -557,6 +557,16 @@
+     if($opt{dbdir}) {
+         $opt{dbdir} =~ /^(.*)$/; $opt{dbdir} = $1;
+     }
++    # untaint what is given on --pidfile. It is not security sensitive since
++    # it is provided by the admin
++    if($opt{pidfile}) {
++        $opt{pidfile} =~ /^(.*)$/; $opt{pidfile} = $1;
++    }
++    # untaint what is given on --inet. It is not security sensitive since
++    # it is provided by the admin
++    if($opt{inet}) {
++        $opt{inet} =~ /^(.*)$/; $opt{inet} = $1;
++    }
+ 
+     # determine proper "logsock" for Sys::Syslog
+     my $syslog_logsock;
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"

Comment 9 Po-Chuan Hsieh 2013-10-19 21:04:17 UTC

State Changed
From-To: feedback->closed

Committed. Thanks!