Bug 181421

Summary: [patch] www/mod_rivet -- update to 2.1.2
Product: Ports & Packages Reporter: Pietro Cerutti <gahr>
Component: Individual Port(s)Assignee: freebsd-apache (Nobody) <apache>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Pietro Cerutti freebsd_committer freebsd_triage 2013-08-20 08:20:00 UTC 

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-08-20 08:20:17 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->apache

apache@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-08-20 08:20:18 UTC 
Maintainer of www/mod_rivet,

Please note that PR ports/181421 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/181421

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2013-08-20 08:20:19 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 jeff.lawson 2013-08-30 23:18:26 UTC 
The upgrade to Rivet 2.1.2 was actually already completed by PR 180444
http://www.freebsd.org/cgi/query-pr.cgi?pr=3D180444

Although the additional configuration options provided by this patch is
functionality and flexibility beyond the scope of the above PR, I don't
think there is sufficient demand for those non-default modes to
necessitate complicating the port installation with them.

Also of note, your patch enforces a USE_TCL=3D86 which is unnecessarily
strict since it prevents users of Tcl 8.5, which is still a supported
version.  USE_TCL=3D85+ is sufficient, and is what was put in place by abov=
e
PR.
Comment 5 Pietro Cerutti freebsd_committer freebsd_triage 2013-09-02 08:36:53 UTC 
On 2013-Aug-30, 22:18, Jeff Lawson wrote:
> The upgrade to Rivet 2.1.2 was actually already completed by PR 180444
> http://www.freebsd.org/cgi/query-pr.cgi?pr=180444


Oh, I must have missed it. 

> 
> Although the additional configuration options provided by this patch is
> functionality and flexibility beyond the scope of the above PR, I don't
> think there is sufficient demand for those non-default modes to
> necessitate complicating the port installation with them.a


I agree that the default installation is probably enough for most users,
but I also think that the two options IMP_NS and EXP_CMD are nice to
have, and the complexity added to the Makefile is really negligeable.
It's just a matter of two OPTIONS and two additional CONFIGURE_ARGS
arguments.

> Also of note, your patch enforces a USE_TCL=86 which is unnecessarily
> strict since it prevents users of Tcl 8.5, which is still a supported
> version.  USE_TCL=85+ is sufficient, and is what was put in place by above
> PR.


Yes, this was probably a left-over of a previous patch. Thanks for
pointing this out.

I'll close this PR now and submit a new one for IMP_NS and EXP_CMD.

-- 
Pietro Cerutti
The FreeBSD Project
gahr@FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp
Comment 6 Pietro Cerutti freebsd_committer freebsd_triage 2013-09-02 08:37:54 UTC 
State Changed
From-To: feedback->closed

Partly duplicate of ports/180444