Bug 181736

Summary: [stage] textproc/domc: simplify and unbreak on sparc64, amd64 (r324422 regression)
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: John Marino <marino>
Status: Closed FIXED    
Severity: Affects Only Me CC: marino
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
shared.diff
none
combined
none
poudriere testport log (9.3R i386) none

Description Jan Beich freebsd_committer freebsd_triage 2013-09-02 00:10:00 UTC 
The vendor Makefile uses same object files to build both static and
shared library. Before r324422 .c.a suffix rule contained a line to
clean up non-pic object files before building SONAME. This was broken
without removing ARNAME from `all' target. Which object files get
-fpic now depends on a race between .c.a and .c.o.

http://pb2.nyi.freebsd.org/bulk/nogcc-default/2013-08-30_22h26m46s/logs/errors/domc-0.8.0_1.log

How-To-Repeat: $ make MAKE_JOBS_NUMBER=1 |& fgrep pic
$ make MAKE_JOBS_NUMBER=16 |& fgrep pic
cc -O2 -pipe -I/usr/local/include -fno-strict-aliasing -Wall -W -g -DMSGNO -I/usr/local/include -L/usr/local/lib -fpic -c -o src/events.o src/events.c
cc -O2 -pipe -I/usr/local/include -fno-strict-aliasing -Wall -W -g -DMSGNO -I/usr/local/include -L/usr/local/lib -fpic -c -o src/node.o src/node.c
Comment 1 Alexey Dokuchaev freebsd_committer freebsd_triage 2013-09-02 13:56:38 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->danfe

Grab it; this is probably my fault. :(
Comment 2 Jan Beich freebsd_committer freebsd_triage 2014-08-13 03:57:05 UTC 
How long is danfe@ going to sit on this trivial PR? A regression is supposed to be fixed promptly, not worked around (in r326330) and then forgotten.

Resetting assignee for better visibility.
Comment 3 Jan Beich freebsd_committer freebsd_triage 2014-08-13 03:59:01 UTC 
Created attachment 145746 [details]
combined

More changes made:
- rebase
- stagify
- fix PREFIX!=LOCALBASE
- fix redefinition of wcwidth(3)
- simplify files/patch-Makefile
- define LICENSE
Comment 4 Jan Beich freebsd_committer freebsd_triage 2014-08-13 04:00:41 UTC 
Created attachment 145747 [details]
poudriere testport log (9.3R i386)
Comment 5 Jan Beich freebsd_committer freebsd_triage 2014-08-13 04:20:52 UTC 
$ portlint -C
WARN: Makefile: only one MASTER_SITE configured.  Consider adding additional mirrors.
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
0 fatal errors and 2 warnings found.
Comment 6 John Marino freebsd_committer freebsd_triage 2014-08-13 05:58:56 UTC 
port has no maintainer, Jan provided updated patch and testlogs -- moving to patch-ready.
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-08-14 22:02:11 UTC 
A commit references this bug:

Author: marino
Date: Thu Aug 14 20:57:31 UTC 2014
New revision: 364867
URL: http://svnweb.freebsd.org/changeset/ports/364867

Log:
  Stage textproc/domc and unbreak on sparc64, amd64

  PR:		181736
  Submitted by:	Jan Beich

Changes:
  head/textproc/domc/Makefile
  head/textproc/domc/files/patch-Makefile
  head/textproc/domc/files/patch-src_defines.h
  head/textproc/domc/files/patch-src_domc.h
  head/textproc/domc/pkg-plist
Comment 8 John Marino freebsd_committer freebsd_triage 2014-08-14 22:09:12 UTC 
thanks!