Bug 18240

Summary: /usr/ports/print/lyx/make doesn't work
Product: Ports & Packages Reporter: dennisjun <dennisjun>
Component: Individual Port(s)Assignee: dirk
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Makefile.patch none

Description dennisjun 2000-04-26 20:00:00 UTC
here's the error message:

<snip>
lyx_cb.o: In function `AutoSave(void)':
lyx_cb.o(.text+0x73dc): warning: tmpnam() possibly used unsafely; consider using mkstemp()
Making all in lib
Making all in reLyX
cp -p ./reLyX.man reLyX.1
cd . && automake --foreign --include-deps Makefile
aclocal.m4: 1630: `AM_PROG_INSTALL' is obsolete; use `AC_PROG_INSTALL'
*** Error code 1

Stop in /usr/ports/print/lyx/work/lyx-1.1.4.
*** Error code 1

Stop in /usr/ports/print/lyx/work/lyx-1.1.4.
*** Error code 1

Stop in /usr/ports/print/lyx.
*** Error code 1

Stop in /usr/ports/print/lyx.
*** Error code 1

Stop in /usr/ports/print/lyx.

Fix: 

don't know, i'm a newbie
How-To-Repeat: /usr/ports/print/lyx/make
Comment 1 dervish 2000-04-26 21:37:41 UTC
Out of da blue dennisjun@yahoo.com aka (dennisjun@yahoo.com) said:
> 
> >Number:         18240
> >Category:       ports
> >Synopsis:       /usr/ports/print/lyx/make  doesn't work
> >Confidential:   no
> >Severity:       critical
> >Priority:       high
> >Responsible:    freebsd-ports
> >State:          open
> >Quarter:        
> >Keywords:       
> >Date-Required:
> >Class:          sw-bug
> >Submitter-Id:   current-users
> >Arrival-Date:   Wed Apr 26 12:00:00 PDT 2000
> >Closed-Date:
> >Last-Modified:
> >Originator:     Dennis Jun
> >Release:        4.0-STABLE
> >Organization:
> >Environment:
> FreeBSD fred 4.0-STABLE FreeBSD 4.0-STABLE #13: Thu Apr 13 16:04:23 EDT 2000     cappy@fred:/usr/src/sys/compile/FRED  i386
> >Description:
> here's the error message:
> 
> <snip>
> lyx_cb.o: In function `AutoSave(void)':
> lyx_cb.o(.text+0x73dc): warning: tmpnam() possibly used unsafely; consider using mkstemp()
> Making all in lib
> Making all in reLyX
> cp -p ./reLyX.man reLyX.1
> cd . && automake --foreign --include-deps Makefile
> aclocal.m4: 1630: `AM_PROG_INSTALL' is obsolete; use `AC_PROG_INSTALL'
> *** Error code 1
> 
> Stop in /usr/ports/print/lyx/work/lyx-1.1.4.
> *** Error code 1
> 
> Stop in /usr/ports/print/lyx/work/lyx-1.1.4.
> *** Error code 1
> 
> Stop in /usr/ports/print/lyx.
> *** Error code 1
> 
> Stop in /usr/ports/print/lyx.
> *** Error code 1
> 
> Stop in /usr/ports/print/lyx.
> >How-To-Repeat:
> /usr/ports/print/lyx/make
> >Fix:
> don't know, i'm a newbie
Need to patch patchfile patch-1.1.4fix2.gz at line #130.
Replace 'AM_PROG_INSTALL' with 'AC_PROG_INSTALL'.
A quick and dirty fix is as follows:
 
cd /usr/ports/print/lyx
make patch
cd work/lyx-1.1.4
vi +1630 aclocal.m4
:s/AM/AC/
:x
cd ../../
make
make install

> 
> >Release-Note:
> >Audit-Trail:
> >Unformatted:
> 
The patch files come from the master site so they
need to be made aware of this ...

#;^)
-- 
f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng.

bush doctor
<dervish@goku.cl.msu.edu>
Comment 2 dervish 2000-04-28 18:22:08 UTC
Out of da blue dennisjun@yahoo.com aka (dennisjun@yahoo.com) said:
> 
> >Number:         18240
> >Category:       ports
> >Synopsis:       /usr/ports/print/lyx/make  doesn't work
> >Confidential:   no
> >Severity:       critical
> >Priority:       high
> >Responsible:    freebsd-ports
> >State:          open
> >Quarter:        
> >Keywords:       
> >Date-Required:
> >Class:          sw-bug
> >Submitter-Id:   current-users
> >Arrival-Date:   Wed Apr 26 12:00:00 PDT 2000
> >Closed-Date:
> >Last-Modified:
> >Originator:     Dennis Jun
> >Release:        4.0-STABLE
> >Organization:
> >Environment:
> FreeBSD fred 4.0-STABLE FreeBSD 4.0-STABLE #13: Thu Apr 13 16:04:23 EDT 2000     cappy@fred:/usr/src/sys/compile/FRED  i386
> >Description:
> here's the error message:
> 
> <snip>
> lyx_cb.o: In function `AutoSave(void)':
> lyx_cb.o(.text+0x73dc): warning: tmpnam() possibly used unsafely; consider using mkstemp()
> Making all in lib
> Making all in reLyX
> cp -p ./reLyX.man reLyX.1
> cd . && automake --foreign --include-deps Makefile
> aclocal.m4: 1630: `AM_PROG_INSTALL' is obsolete; use `AC_PROG_INSTALL'
> *** Error code 1
> 
> Stop in /usr/ports/print/lyx/work/lyx-1.1.4.
> *** Error code 1
> 
> Stop in /usr/ports/print/lyx/work/lyx-1.1.4.
> *** Error code 1
> 
> Stop in /usr/ports/print/lyx.
> *** Error code 1
> 
> Stop in /usr/ports/print/lyx.
> *** Error code 1
> 
> Stop in /usr/ports/print/lyx.
> >How-To-Repeat:
> /usr/ports/print/lyx/make
> >Fix:
> don't know, i'm a newbie
After sending what I thought was the fix to the lyx bugs list,
I was told that I should have read the patch file.  All that
needs to be done after the patch is to touch some Makefile.in
files.  Here's what I've done to fix this port.  Please review
at your earliest.  Enjoy!!!  Makefile.patch is attached.

--- /usr/ports/print/lyx/Makefile.orig	Fri Apr 28 12:12:29 2000
+++ /usr/ports/print/lyx/Makefile	Fri Apr 28 13:11:38 2000
@@ -41,4 +41,11 @@
 	@${ECHO_MSG} "make WITH_ISPELL=yes"
 .endif
 
+post-patch:
+	@touch ${WRKSRC}/Makefile.in ${WRKSRC}/intl/Makefile.in
+	@touch ${WRKSRC}/src/Makefile.in ${WRKSRC}/src/mathed/Makefile.in
+	@touch ${WRKSRC}/src/insets/Makefile.in ${WRKSRC}/src/support/Makefile.in
+	@touch ${WRKSRC}/lib/Makefile.in ${WRKSRC}/lib/reLyX/Makefile.in
+	@touch ${WRKSRC}/src/config.h.in
+
 .include <bsd.port.mk>

> 
> >Release-Note:
> >Audit-Trail:
> >Unformatted:
> 
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-ports" in the body of the message

-- 
f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng.

bush doctor
<dervish@goku.cl.msu.edu>
Comment 3 Akinori MUSHA 2000-04-28 20:47:37 UTC
At Fri, 28 Apr 2000 10:30:03 -0700 (PDT),
Bush Doctor <dervish@goku.cl.msu.edu> wrote:
>  +post-patch:
>  +	@touch ${WRKSRC}/Makefile.in ${WRKSRC}/intl/Makefile.in
>  +	@touch ${WRKSRC}/src/Makefile.in ${WRKSRC}/src/mathed/Makefile.in
>  +	@touch ${WRKSRC}/src/insets/Makefile.in ${WRKSRC}/src/support/Makefile.in
>  +	@touch ${WRKSRC}/lib/Makefile.in ${WRKSRC}/lib/reLyX/Makefile.in
>  +	@touch ${WRKSRC}/src/config.h.in
>  +
>   .include <bsd.port.mk>

How about using find(1) ?

a)	@find ${WRKSRC} -name '*.in' | xargs ${TOUCH}
b)	@find ${WRKSRC} -name '*.in' -exec ${TOUCH} ';'

Untested myself, though.

-- 
                           /
                          /__  __       
                         / )  )  ) )  /
Akinori -Aki- MUSHA aka / (_ /  ( (__(  @ idaemons.org / FreeBSD.org

"We're only at home when we're on the run, on the wing, on the fly"
Comment 4 dervish 2000-04-28 21:15:10 UTC
Out of da blue Akinori -Aki- MUSHA aka (knu@idaemons.org) said:
> At Fri, 28 Apr 2000 10:30:03 -0700 (PDT),
> Bush Doctor <dervish@goku.cl.msu.edu> wrote:
> >  +post-patch:
> >  +	@touch ${WRKSRC}/Makefile.in ${WRKSRC}/intl/Makefile.in
> >  +	@touch ${WRKSRC}/src/Makefile.in ${WRKSRC}/src/mathed/Makefile.in
> >  +	@touch ${WRKSRC}/src/insets/Makefile.in ${WRKSRC}/src/support/Makefile.in
> >  +	@touch ${WRKSRC}/lib/Makefile.in ${WRKSRC}/lib/reLyX/Makefile.in
> >  +	@touch ${WRKSRC}/src/config.h.in
> >  +
> >   .include <bsd.port.mk>
> 
> How about using find(1) ?
> 
> a)	@find ${WRKSRC} -name '*.in' | xargs ${TOUCH}
> b)	@find ${WRKSRC} -name '*.in' -exec ${TOUCH} ';'
Ok, you've given me some insight.  We want every Makefile.in
in ${WRKSRC} along with src/config.h.in. So how about

a)	@find ${WRKSRC} -name 'Makefile.in' | xargs ${TOUCH}
	@${TOUCH} ${WRKSRC}/src/config.h.in

b)	@find ${WRKSRC} -name 'Makefile.in' -exec ${TOUCH} ';'
	@${TOUCH} ${WRKSRC}/src/config.h.in

> 
> Untested myself, though.
I've tested both methods, no problems.  It's just a matter of choosing
either a or b.

> 
> -- 
>                            /
>                           /__  __       
>                          / )  )  ) )  /
> Akinori -Aki- MUSHA aka / (_ /  ( (__(  @ idaemons.org / FreeBSD.org
> 
> "We're only at home when we're on the run, on the wing, on the fly"


#;^)
-- 
f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng.

bush doctor
<dervish@goku.cl.msu.edu>
Comment 5 Steve Price freebsd_committer freebsd_triage 2000-04-30 00:25:28 UTC
Responsible Changed
From-To: freebsd-ports->dirk

Over to port's maintainer. 
Comment 6 dirk freebsd_committer freebsd_triage 2000-05-01 22:04:32 UTC
State Changed
From-To: open->closed

Fixed via touch in post-patch.