Bug 18271

Summary: [patch] simplelock: klds not portable across UP and SMP
Product: Base System Reporter: Jake Burkholder <jake>
Component: kernAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 5.0-CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Jake Burkholder 2000-04-28 16:10:01 UTC 
Due to the fact that the simplelock functions are #defined to nothing in
the UP kernel, klds compiled on a UP machine will have no simplelock calls
at all, and thus none of the necesary SMP locking if loaded on such a
machine.  This patch makes simplelock a function call for klds, and adds
empty bodied functions to the UP kernel which are used in that case.

At least the following modules are affected:
	ccd
	cd9660
	msdosfs
	nfs
	ntfs
	nwfs
	vinum

Which need to be recompiled.

How-To-Repeat: 
n/a
Comment 1 John-Mark Gurney freebsd_committer freebsd_triage 2003-06-21 04:19:34 UTC 
Responsible Changed
From-To: freebsd-bugs->jake

Jake, you can take your own pr's :)
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2005-08-27 14:44:26 UTC 
Responsible Changed
From-To: jake->freebsd-bugs

jake's email is now bouncing; there have been no commits made in over 
a year. 

Does anyone know if this problem still exists?  This PR is antique.
Comment 3 Matteo Riondato freebsd_committer freebsd_triage 2005-08-27 15:05:27 UTC 
Il giorno sab, 27/08/2005 alle 13.46 +0000, Mark Linimon ha scritto:
> Synopsis: simplelock: klds not portable across UP and SMP
> 
> Responsible-Changed-From-To: jake->freebsd-bugs
> Responsible-Changed-By: linimon
> Responsible-Changed-When: Sat Aug 27 13:44:26 GMT 2005
> Responsible-Changed-Why: 
> jake's email is now bouncing; there have been no commits made in over
> a year.
> 
> Does anyone know if this problem still exists?  This PR is antique.

It seems to me that simplelocks were converted to mutexes in rev 1.25 of
sys/sys/lock.h . To answer you question: I don't know but if it still
exists, it's probably releated to something else, so I would close this
PR.
Best Regards
-- 
Matteo Riondato
FreeBSD Volunteer (http://www.FreeBSD.org/)
GUFI Staff Member (http://www.GUFI.org/)
FreeSBIE Developer (http://www.FreeSBIE.org/)
Comment 4 Eitan Adler freebsd_committer freebsd_triage 2011-03-12 22:38:52 UTC 
State Changed
From-To: open->closed

per feedback