Bug 182923

Summary:	some ports still require WITH_PKGNG=1
Product:	Ports & Packages	Reporter:	dt71
Component:	Individual Port(s)	Assignee:	Stefan Walter <stefan>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Latest
Hardware:	Any
OS:	Any

Description dt71 2013-10-12 15:30:00 UTC

pkgng should be default package management tool on both -CURRENT and 11.0-RELEASE. This means that people who do not want to use pkgng should add WITHOUT_PKGNG=1 to /etc/make.conf (as opposed to: people who do want to use pkgng should add WITH_PKGNG=1). Yet, there are still a few ports that use ".if defined(WITH_PKGNG)" checks in the relevant Makefile; for example, if the system uses pkgng (pkg2ng has been run, or vice versa), then the ports-mgmt/pkg_cutleaves port will not work (the program will not find any packages installed) unless WITH_PKGNG=1 is specified. It is time to change this behavior, ie., the Makefiles in each port directory should be altered to use ".if defined(WITHOUT_PKGNG)" or similar checks.

How-To-Repeat: 1. Use pkgng.
2. Remove the WITH_PKGNG=1 setting from /etc/make.conf, if present.
3. Build and (re)install ports-mgmt/pkg_cutleaves.
4. Run pkg_cutleaves; notice that the program doesn't find any ports installed.

Comment 1 Tilman Keskinoz freebsd_committer

2014-01-02 16:17:02 UTC

Responsible Changed
From-To: freebsd-ports-bugs->stefan

Over to maintainer

Comment 2 commit-hook freebsd_committer

2014-06-07 18:47:24 UTC

A commit references this bug:

Author: stefan
Date: Sat Jun  7 18:47:00 UTC 2014
New revision: 356942
URL: http://svnweb.freebsd.org/changeset/ports/356942

Log:
  Properly include bsd.port.pre.mk before checking for WITH_PKGNG, so that
  explicitly setting the latter on FreeBSD 10 is not required.

  PR:		182923
  Submitted by:	dt71@gmx.com

Changes:
  head/ports-mgmt/pkg_cutleaves/Makefile

Comment 3 Stefan Walter freebsd_committer

2014-06-07 19:26:42 UTC

Finally fixed this in ports-mgmt/pkg_cutleaves.