Bug 183333

Summary: Misnamed constant in bpf(4)
Product: Documentation Reporter: Mats Erik Andersson <bsd>
Component: Manual PagesAssignee: Guangyuan Yang <ygy>
Status: Closed FIXED    
Severity: Affects Only Me CC: doc, felix.the.red, ygy
Priority: Normal Keywords: easy, patch
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
bpf(4) patch none

Description Mats Erik Andersson 2013-10-26 15:10:00 UTC 
In section EXAMPLES of bpf(4), first example on Reverse ARP,
the macro REVARP_REQUEST does not exist. The code snippet
must be updated to use ARPOP_REVREQUEST instead. For verification
look in "/usr/include/net/if_arp.h".

Fix: 

Use macro ARPOP_REVREQUEST.
Comment 1 pluknet 2013-10-26 17:49:50 UTC 
The bpf(4) documentation states that the example is taken from the Reverse
ARP Daemon.  rarpd is tightly coupled with BPF.  This macro is actually
used there mapped to ARPOP_REVREQUEST.  From rarpd code snippet's p.o.v.
this EXAMPLES is correct, but is not compilable as is without adding this
mapping there.

The REVARP_REQUEST localism is probably came from SunOS? (and RFC1931).
This macro does not exist in net/if_arp.h (in any BSD except Solaris) and
is/was probably used for source compatibility with SunOS.
The ARPOP_REVREQUEST macro sits there since 1992 (4.4BSD).  SunOS took
if_arp.h from UCB on 1/24/86 and added REVARP_REQUEST on its own.  It seems
to not have ARPOP_REVREQUEST.

wpaul modified rarpd.c in r19859 to use REVARP_REQUEST (it was
ARPOP_REVREQUEST there originally r6823).  The bpf(4) man page came in with
r5882 from 1.1.5, and it was REVARP_REQUEST there.  It was REVARP_REQUEST
in rarpd as found in 4.3BSD-UWisc copyrighted by Sun Micro dated 86/02/05
which is before 1992.


-- 
wbr,
pluknet
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:58:55 UTC 
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 3 Felix Johnson 2021-09-25 05:59:26 UTC 
Created attachment 228158 [details]
bpf(4) patch

Change constant REVARP_REQUEST to ARPOP_REVREQUEST.
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-10-13 23:03:48 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=a524aaf68341d9f83a0ef7dc21ad54728ddaaa1e

commit a524aaf68341d9f83a0ef7dc21ad54728ddaaa1e
Author:     Felix Johnson <felix.the.red@gmail.com>
AuthorDate: 2021-10-13 23:00:41 +0000
Commit:     Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2021-10-13 23:03:18 +0000

    bpf(4): Fix a misnamed constant

    rarpd.c was modified in r19859 to use REVARP_REQUEST instead of
    ARPOP_REVREQUEST.

    PR:             183333
    MFC after:      3 days
    Reported by:    pluknet <pluknet@gmail.com>

 share/man/man4/bpf.4 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-10-18 19:17:36 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=351cad089f204bb3a706dfefe1720736150778b0

commit 351cad089f204bb3a706dfefe1720736150778b0
Author:     Felix Johnson <felix.the.red@gmail.com>
AuthorDate: 2021-10-13 23:00:41 +0000
Commit:     Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2021-10-18 19:16:01 +0000

    bpf(4): Fix a misnamed constant

    rarpd.c was modified in r19859 to use REVARP_REQUEST instead of
    ARPOP_REVREQUEST.

    PR:             183333
    Reported by:    pluknet <pluknet@gmail.com>

    (cherry picked from commit a524aaf68341d9f83a0ef7dc21ad54728ddaaa1e)

 share/man/man4/bpf.4 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)