Bug 183584

Summary: [libcrypto] [patch] crypto/openssl: NIST P-* elliptic curves aren't optimized on amd64
Product: Base System Reporter: Yasar Kanis <yanis>
Component: kernAssignee: Jung-uk Kim <jkim>
Status: Closed Not Accepted    
Severity: Affects Only Me CC: arrowd, jhb
Priority: Normal    
Version: 10.0-BETA2   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
ec_nistp_opt.patch none

Description Yasar Kanis 2013-11-02 06:30:00 UTC
When running security/tor-devel the following message ends up in the
log file.

[notice] We were built to run on a 64-bit CPU, with OpenSSL 1.0.1 or later, but with a version of OpenSSL that apparently lacks accelerated support for the NIST P-224 and P-256 groups. Building openssl with such support (using the enable-ec_nistp_64_gcc_128 option when configuring it) would make ECDH much faster.

How-To-Repeat:  % nm -D /lib/libcrypto.so.7 | grep ec_GFp_nistp224_points_mul
 <empty>
Comment 1 John-Mark Gurney freebsd_committer freebsd_triage 2014-01-24 21:55:02 UTC
Responsible Changed
From-To: freebsd-bugs->jmg

I'll look at pushing this through...
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:59:09 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 3 Gleb Popov freebsd_committer freebsd_triage 2020-03-29 17:57:00 UTC
Seems to be still relevant in 2020. Can this be commited?
Comment 4 John Baldwin freebsd_committer freebsd_triage 2021-05-26 21:27:06 UTC
Passing to jkim@ so he can evaluate this.
Comment 5 Jung-uk Kim freebsd_committer freebsd_triage 2021-05-28 18:07:24 UTC
We try to keep default options as much as possible because it is hard to maintain non-default features.  This option is disabled by default because this feature has strict requirements, i.e., a) little-endian platforms, b) unaligned memory access, and c) GCC compiler extension __int128_t.  We *may* enable this feature only for amd64 and make it src.conf option but it is going to be hard to maintain.
Comment 6 Jung-uk Kim freebsd_committer freebsd_triage 2021-05-28 18:09:42 UTC
Sorry, this patch is not acceptable.