Bug 184043

Summary: maintainer update: Upgrade net-mgmt/bsnmptools to version 20100516-01
Product: Ports & Packages Reporter: Carlos Santos <unixmania>
Component: Individual Port(s)Assignee: David Naylor <dbn>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
bsnmptools_diff_a.txt none

Description Carlos Santos 2013-11-18 02:00:00 UTC 
Upgrade net-mgmt/bsnmptools to version 20100516-01

- New distribution file
- Adapt the build parameters accordingly
- Restrict the package to pre-9.x OS versions

Client tools (including SNMPv3 support) were incorporated to
the base system in FreeBSD 9.0. I'm keeping this port because
it may still be useful on FreeBSD 8.x and below.

Fix: n.a.

Patch attached with submission follows:
How-To-Repeat: n.a.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-18 02:00:08 UTC 
Class Changed
From-To: maintainer-update->change-request

Fix category (submitter is not maintainer) (via the GNATS Auto Assign 
Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-18 02:00:09 UTC 
Maintainer of net-mgmt/bsnmptools,

Please note that PR ports/184043 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/184043

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2013-11-18 02:00:10 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2013-11-18 04:06:33 UTC 
State Changed
From-To: feedback->open

Submitter is maintainer.  Address was in error.
Comment 5 Carlos Santos 2013-11-21 11:06:36 UTC 
Of course I agree, since it is a maintainer update and I am the maintainer.
:-)
Comment 6 David Naylor freebsd_committer freebsd_triage 2013-12-01 16:54:10 UTC 
Hi Carlos,

Could you please address the following three issues with your patch:

 1) Please correct me if I'm wrong but wasn't bsnmptools imported (r216295) 
between OSVERSION 900027 (r216212) and OSVERSION 900028 (r216615) therefore 
the check in your patch should be for ${OSVERSION} >= 900028.  

 2) Please change the patch to support staging.  

 3) Normally OSVERSION should be paired with OPSYS (i.e. if ${OPSYS} == 
FreeBSD && ${OSVERSION} >= 900028).  For example: lang/nqc.  


Comments on the above:

 1) This is based on a quick check however I think you may know better than I.  

 2) All new ports and changes to existing ports should add support for staging 
where reasonably possible.  In this case I do not foresee any difficulty in 
adding stage support (I think all that needs to be done to remove NO_STAGE and 
MAN? and add the man files to the package list).  

 3) This is for compatibility as other BSDs may use our ports collection, for 
example DragonflyBSD.  This appears to be a relatively new initiative and is 
not policy yet.  Feel free to ignore this point if you want :-).  


Regards,

David
Comment 7 David Naylor freebsd_committer freebsd_triage 2013-12-01 17:01:54 UTC 
On Sunday, 1 December 2013 19:54:10 David Naylor wrote:
> Hi Carlos,
> 
> Could you please address the following three issues with your patch:
> 
>  1) Please correct me if I'm wrong but wasn't bsnmptools imported (r216295)
> between OSVERSION 900027 (r216212) and OSVERSION 900028 (r216615) therefore
> the check in your patch should be for ${OSVERSION} >= 900028.
> 
>  2) Please change the patch to support staging.
> 
>  3) Normally OSVERSION should be paired with OPSYS (i.e. if ${OPSYS} ==
> FreeBSD && ${OSVERSION} >= 900028).  For example: lang/nqc.
> 
> 
> Comments on the above:
> 
>  1) This is based on a quick check however I think you may know better than
> I.
> 
>  2) All new ports and changes to existing ports should add support for
> staging where reasonably possible.  In this case I do not foresee any
> difficulty in adding stage support (I think all that needs to be done to
> remove NO_STAGE and MAN? and add the man files to the package list).
> 
>  3) This is for compatibility as other BSDs may use our ports collection,
> for example DragonflyBSD.  This appears to be a relatively new initiative
> and is not policy yet.  Feel free to ignore this point if you want :-).

Apologies, please also address the following issues as identified by portlint:

 4) WARN: /home/freebsd/ports/net-mgmt/bsnmptools/pkg-descr: use WWW: with a 
single space, then http://wiki.freebsd.org/BsnmpTools

 5) WARN: Makefile: CFLAGS is overridden in the Makefile clobbering a value 
possibly set by a user.  Consider using CFLAGS+=... if you want to add or 
CFLAGS:=${CFLAGS:C/...//} if you want to remove specific flags

 6) FATAL: Makefile: either PORTVERSION or DISTVERSION must be specified, not 
both.

 7) WARN: Makefile: Consider defining LICENSE.

 8) WARN: Makefile: Consider adding STAGE support.

Note: 8 is a duplicate of item 2 above and is included for completeness.  

If you have any questions please ask.  

Regards
Comment 8 David Naylor freebsd_committer freebsd_triage 2013-12-01 17:33:52 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->dbn

I'll take this one
Comment 9 Carlos Santos 2013-12-02 01:45:44 UTC 
David,

Thanks for your help. Plase see my answers below. I'm sending a new
patch that fixes most of the issues you found.

On Sun, Dec 1, 2013 at 3:01 PM, David Naylor <dbn@freebsd.org> wrote:
>  1) Please correct me if I'm wrong but wasn't bsnmptools imported (r216295)
> between OSVERSION 900027 (r216212) and OSVERSION 900028 (r216615) therefore
> the check in your patch should be for ${OSVERSION} >= 900028.

Fixed in attached patch.

>  2) Please change the patch to support staging.

See comment below.

>  3) Normally OSVERSION should be paired with OPSYS (i.e. if ${OPSYS} ==
> FreeBSD && ${OSVERSION} >= 900028).  For example: lang/nqc.

Fixed in attached patch (though I'm not sure if bsnmptools is
available on othet BSD.

> Comments on the above:

>  2) All new ports and changes to existing ports should add support for
> staging where reasonably possible.  In this case I do not foresee any
> difficulty in adding stage support (I think all that needs to be done to
> remove NO_STAGE and MAN? and add the man files to the package list).

Too much hassle for a port aiming old OS releases that will probably
be retired soon.

>  4) WARN: /home/freebsd/ports/net-mgmt/bsnmptools/pkg-descr: use WWW: with a
> single space, then http://wiki.freebsd.org/BsnmpTools

Fixed in attached patch.

>  5) WARN: Makefile: CFLAGS is overridden in the Makefile clobbering a value
> possibly set by a user.  Consider using CFLAGS+=... if you want to add or
> CFLAGS:=${CFLAGS:C/...//} if you want to remove specific flags

I don't see this. There is no CFLAGS in the Makefile. Perhaps you ran
portlint with the old Makefile.

>  6) FATAL: Makefile: either PORTVERSION or DISTVERSION must be specified, not
> both.

Fixed in attached patch.

>  7) WARN: Makefile: Consider defining LICENSE.

Fixed in attached patch.

>  8) WARN: Makefile: Consider adding STAGE support.
>
> Note: 8 is a duplicate of item 2 above and is included for completeness.
Comment 10 dfilter service freebsd_committer freebsd_triage 2013-12-02 17:24:31 UTC 
Author: dbn
Date: Mon Dec  2 17:24:22 2013
New Revision: 335515
URL: http://svnweb.freebsd.org/changeset/ports/335515

Log:
  Update net-mgmt/bsnmptools to 0.0.20060818.
  
  Changes:
   * Add license (BSD)
   * Restrict to pre FreeBSD 9 (included in base)
   * Add stage support
  
  PR:		ports/184043
  Submitted by:	Carlos A. M. dos Santos <unixmania@gmail.com> (maintainer)

Modified:
  head/net-mgmt/bsnmptools/Makefile
  head/net-mgmt/bsnmptools/distinfo
  head/net-mgmt/bsnmptools/pkg-descr

Modified: head/net-mgmt/bsnmptools/Makefile
==============================================================================
--- head/net-mgmt/bsnmptools/Makefile	Mon Dec  2 17:18:06 2013	(r335514)
+++ head/net-mgmt/bsnmptools/Makefile	Mon Dec  2 17:24:22 2013	(r335515)
@@ -2,37 +2,34 @@
 # $FreeBSD$
 
 PORTNAME=	bsnmptools
-PORTVERSION=	0.0.20060818
-DISTVERSION=	20060818-01
-PORTREVISION=	2
+PORTVERSION=	0.0.20100516
 CATEGORIES=	net-mgmt
-MASTER_SITES=	http://www.ringlet.net/~shteryana/snmp/ CENKES
+MASTER_SITES=	http://people.freebsd.org/~syrinx/snmp/ CENKES
+DISTNAME=	bsnmptools-20100516-01
 EXTRACT_SUFX=	.tar
 
 MAINTAINER=	unixmania@gmail.com
 COMMENT=	Snmp client tools
 
+LICENSE=	BSD
+
+.include <bsd.port.pre.mk>
+
+.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 900028
+IGNORE=		client tools (including SNMPv3 support) are part of the base system
+.endif
+
 USE_LDCONFIG=	yes
-WRKSRC=		${WRKDIR}/${PORTNAME}
+WRKSRC=		${WRKDIR}/bsnmptools/usr.sbin/bsnmpd/tools
 MAKE_ARGS=	SHLIB_MAJOR=0 INCLUDEDIR=${PREFIX}/include LIBDIR=${PREFIX}/lib \
 		MANDIR=${MANPREFIX}/man/man NO_MANCOMPRESS=yes BINDIR=${PREFIX}/bin \
 		NO_PROFILE=yes
-CFLAGS=		-I${WRKSRC}/lib -L${WRKSRC}/lib
-PLIST_FILES=	${BIN_FILES:S,^,bin/,} include/${PORTNAME}.h include/bsnmptc.h \
-		lib/lib${PORTNAME}.a lib/lib${PORTNAME}.so lib/lib${PORTNAME}.so.0
+PLIST_FILES=	${BIN_FILES:S,^,bin/,} \
+		lib/lib${PORTNAME}.a lib/lib${PORTNAME}.so lib/lib${PORTNAME}.so.0 \
+		${BIN_FILES:S,^,man/man1/,:S,$,.1.gz,}
 BIN_FILES=	bsnmpget bsnmpset bsnmpwalk
-MAN1=	${BIN_FILES:S/$/.1/}
-MAN3=	${PORTNAME}.3
-
-NO_STAGE=	yes
-post-extract:
-	@${CHMOD} -R u+w ${WRKSRC}
-	@${MV} ${WRKSRC}/lib/libbsnmptools/libbsnmptools ${WRKSRC}/tlib
-	@${MV} ${WRKSRC}/usr.sbin/bsnmpd/tools ${WRKSRC}/
-	@${RM} -rf ${WRKSRC}/lib ${WRKSRC}/usr.sbin ${WRKSRC}/tools/Makefile.inc
-	@${MV} ${WRKSRC}/tlib ${WRKSRC}/lib
 
 post-patch:
-	@${REINPLACE_CMD} -e 's/usr.sbin/tools/' ${WRKSRC}/Makefile
+	@${REINPLACE_CMD} -e 's|$${DESTDIR}/usr/bin|$${STAGEDIR}$${BINDIR}|g' ${WRKSRC}/bsnmptools/Makefile
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>

Modified: head/net-mgmt/bsnmptools/distinfo
==============================================================================
--- head/net-mgmt/bsnmptools/distinfo	Mon Dec  2 17:18:06 2013	(r335514)
+++ head/net-mgmt/bsnmptools/distinfo	Mon Dec  2 17:24:22 2013	(r335515)
@@ -1,2 +1,2 @@
-SHA256 (bsnmptools-20060818-01.tar) = 0537938014c5af4eb33fe37ff4807f144cce1c3d60699e2eed477c4b8a506020
-SIZE (bsnmptools-20060818-01.tar) = 40407
+SHA256 (bsnmptools-20100516-01.tar) = f911ca96a513977020d50809d9ec08592c104a4f220a387c5a7fa91eb414acda
+SIZE (bsnmptools-20100516-01.tar) = 39022

Modified: head/net-mgmt/bsnmptools/pkg-descr
==============================================================================
--- head/net-mgmt/bsnmptools/pkg-descr	Mon Dec  2 17:18:06 2013	(r335514)
+++ head/net-mgmt/bsnmptools/pkg-descr	Mon Dec  2 17:24:22 2013	(r335515)
@@ -1,3 +1,3 @@
 Snmp client-side tools
 
-WWW:	http://wiki.freebsd.org/BsnmpTools
+WWW: http://wiki.freebsd.org/BsnmpTools
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 11 David Naylor freebsd_committer freebsd_triage 2013-12-02 17:26:21 UTC 
State Changed
From-To: open->closed

Committed, with minor changes.  Thanks!