Bug 184585
| Summary: | [exp-run] Update graphics/jbigkit to 2.0 [patch] | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Adam Weinberger <adamw> | ||||||||||
| Component: | Ports Framework | Assignee: | Port Management Team <portmgr> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | bapt, freebsd-2024 | ||||||||||
| Priority: | Normal | Flags: | bapt:
exp-run+
|
||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Adam Weinberger
2013-12-07 21:40:01 UTC
Responsible Changed From-To: freebsd-ports-bugs->mi mi@aldan.algebra.com => mi@ (via the GNATS Auto Assign Tool) Maintainer of graphics/jbigkit,
Please note that PR ports/184585 has just been submitted.
If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.
The full text of the PR can be found at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/184585
--
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool) State Changed From-To: feedback->open I'm going to consider this a maintainer timout. I'll take this and usher it through the rest of the way. mi, shoot me an email if you want otherwise. Responsible Changed From-To: mi->adamw I'm going to consider this a maintainer timout. I'll take this and usher it through the rest of the way. mi, shoot me an email if you want otherwise. Responsible Changed From-To: adamw->portmgr Assigning to portmgr. Can we please do an exp-run with this change? It *should* be a NOOP, as the old jbigkit library hasn't really changed, but I'd like to make sure of it. Responsible Changed From-To: portmgr->bdrewery take for exp-run (currently behind) Sorry, I have been behind. I went to do the exp-run on this today. Unfortunately the patch does not apply. The patch modifies files/patch-Makefile, files/patch-pbmtools_Makefile and files/patch-libjbig_Makefile. I don't see these files in head or ever existing for graphics/jbigkit -- Regards, Bryan Drewery Yeah, you're right. I had attempted to include some svn mv stuff in there to improve patch filenames but it didn't come out clearly in the patch. The files/ stuff will apply if you: # mv patch-aa patch-Makefile # mv patch-ab patch-libjbig_Makefile # mv patch-ac patch-pbmtools_Makefile The Makefile portion is also not likely to apply, as miwi just added STAGE support to the port. I'll redo the patch again, but if you sit on it for a month again then you get to recreate it next time ;-) # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org Regenerated patch attached. If I attached it wrong I can put it up on people.freebsd.org. # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org > On Feb 2, 2014, at 13:10, Adam Weinberger <adamw@FreeBSD.org> wrote: > > Regenerated patch attached. If I attached it wrong I can put it up on > people.freebsd.org. > Thanks, starting it now. Will have results tomorrow. > # Adam > > > -- > Adam Weinberger > adamw@adamw.org > http://www.adamw.org > <jbigkit2.patch> jbigkit failed: http://package18.nyi.freebsd.org/bulk/91amd64-default-pr_184585/2014-02-02_20h39m24s/logs/errors/jbigkit-2.0.log -- Regards, Bryan Drewery Responsible Changed From-To: bdrewery->adamw back to adamw, jbigkit fails Phew, I'm relieved here... I couldn't figure out the compilation problem. Your patch should probably avoid NOPORTDOCS though... # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org Responsible Changed From-To: adamw->portmgr Can we, please, have another exp-run? Thank you. Responsible Changed From-To: portmgr->bdrewery take for exp-run Responsible Changed From-To: bdrewery->adamw exp-run done, no new failures. Responsible Changed From-To: adamw->mi I'll see to it... Unfortunately, according to Markus Kuhn -- the author of jbigkit -- the changes between 1.6 and 2.x are significant enough to require bumping the shared library's major number: welcome libjbig.so.2. The attached patch includes that and, I suspect, warrants yet another exp-run. Responsible Changed From-To: mi->portmgr Another exp-run is, likely, needed because the major number of libjbig.so must be bumped from 1 to 2. Infrastructure PR. A commit references this bug: Author: mi Date: Sat Jun 21 21:44:47 UTC 2014 New revision: 358748 URL: http://svnweb.freebsd.org/changeset/ports/358748 Log: Upgrade from 1.8 to 2.1 PR: 184585 Submitted by: Adam Weinberger Changes: head/graphics/jbigkit/Makefile head/graphics/jbigkit/distinfo head/graphics/jbigkit/files/patch-aa head/graphics/jbigkit/files/patch-ab head/graphics/jbigkit/files/patch-ac head/graphics/jbigkit/files/patch-warnings head/graphics/jbigkit/pkg-plist |