Summary: | [armv6] issues with dhclient/sshd and jemalloc on raspberry pi and others | ||
---|---|---|---|
Product: | Base System | Reporter: | Adrian Chadd <adrian> |
Component: | arm | Assignee: | freebsd-arm (Nobody) <freebsd-arm> |
Status: | Closed FIXED | ||
Severity: | Affects Only Me | ||
Priority: | Normal | ||
Version: | 1.0-CURRENT | ||
Hardware: | Any | ||
OS: | Any |
Description
Adrian Chadd
2013-12-20 20:40:00 UTC
Author: adrian Date: Fri Dec 27 05:01:13 2013 New Revision: 259936 URL: http://svnweb.freebsd.org/changeset/base/259936 Log: Revert r252694 - which attempted to fix bit emulation for armv6/armv7. This seems to cause issues with jemalloc + {dhclient, sshd}. Thus, revert this for now until the root cause can be found and fixed. This should quieten some runtime problems with the Raspberry Pi. PR: kern/185046 MFC after: 3 days Modified: head/sys/arm/arm/pmap-v6.c Modified: head/sys/arm/arm/pmap-v6.c ============================================================================== --- head/sys/arm/arm/pmap-v6.c Fri Dec 27 04:30:32 2013 (r259935) +++ head/sys/arm/arm/pmap-v6.c Fri Dec 27 05:01:13 2013 (r259936) @@ -3094,21 +3094,16 @@ validate: if ((m->oflags & VPO_UNMANAGED) == 0) { vm_page_aflag_set(m, PGA_WRITEABLE); /* - * Enable write permission if the access type - * indicates write intention. Emulate modified - * bit otherwise. + * XXX: Skip modified bit emulation for now. + * The emulation reveals problems + * that result in random failures + * during memory allocation on some + * platforms. + * Therefore, the page is marked RW + * immediately. */ - if ((access & VM_PROT_WRITE) != 0) { - npte &= ~(L2_APX); - /* - * The access type and permissions - * indicate that the page will be - * written as soon as returned from - * fault service. - * Mark it dirty from the outset. - */ - vm_page_dirty(m); - } + npte &= ~(L2_APX); + vm_page_dirty(m); } else npte &= ~(L2_APX); } _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" Author: adrian Date: Fri Dec 27 22:05:51 2013 New Revision: 259963 URL: http://svnweb.freebsd.org/changeset/base/259963 Log: Revert r252694 from stable/10 to fix instabilities seen with jemalloc + dhclient/sshd. This is a direct commit to stable/10 as the VM code has changed since the stable/10 branch. PR: kern/185046 Modified: stable/10/sys/arm/arm/pmap-v6.c Modified: stable/10/sys/arm/arm/pmap-v6.c ============================================================================== --- stable/10/sys/arm/arm/pmap-v6.c Fri Dec 27 22:00:22 2013 (r259962) +++ stable/10/sys/arm/arm/pmap-v6.c Fri Dec 27 22:05:51 2013 (r259963) @@ -3087,13 +3087,8 @@ validate: } if (prot & VM_PROT_WRITE) { - /* - * Enable write permission if the access type - * indicates write intention. Emulate modified - * bit otherwise. - */ - if ((access & VM_PROT_WRITE) != 0) - npte &= ~(L2_APX); + /* Write enable */ + npte &= ~(L2_APX); if ((m->oflags & VPO_UNMANAGED) == 0) { vm_page_aflag_set(m, PGA_WRITEABLE); _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" Closing this based on the commit log in r259963. Thank you for the report. |