Bug 18505

Summary: missing VFS_START call.
Product: Base System Reporter: mellon <mellon>
Component: kernAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 5.0-CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description mellon 2000-05-11 18:20:01 UTC
VFS_START is not called after VFS_MOUNT in vfs_mountroot_try (vfs_conf.c).
This is contrary to VFS_START's intention and documentation. The deed
only goes unpunished because no filesystem currently does anything on
VFS_START except MFS, but it's only a matter of time before some might
try something. MFS grabs the calling process and turns it into a workhorse
on VFS_START, but MFS won't mount as root so it's okay (and correct) 
to call VFS_START there.

Fix: Two choices:
1) Document VFS_START as a dirty hack made especially for MFS which no
other filesystems should ever use or rely on;
2) (preferrable IMHO) apply the patch below. It also fixes a typo in
the comment for MFS code which stops it from mounting as root.
Comment 1 mux freebsd_committer freebsd_triage 2002-07-08 20:12:43 UTC
State Changed
From-To: open->closed