Summary: | [NEW PORT] devel/py-peewee (a small, expressive Python ORM) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Matthias Petermann <matthias> | ||||||
Component: | Individual Port(s) | Assignee: | Marcus von Appen <mva> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | ||||||||
Priority: | Normal | ||||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Matthias Petermann
2014-01-04 18:10:00 UTC
Responsible Changed From-To: freebsd-ports-bugs->freebsd-python freebsd-python@ wants this port PRs (via the GNATS Auto Assign Tool) Responsible Changed From-To: freebsd-python->mva I'll take it. Thanks for your submission. Ther are some minor issues with the port, though. - Please avoid indefinite articles at the beginning of a COMMENT - Usage of USE_PYDISTUTILS=easy_install is deprecated. Please use USE_PYDISTUTILS=yes instead. - Python 2.6 has beend removed from the ports tree, so your port should use USE_PYTHON=2.7+. - You also can simplify the options by using SQLITE_RUN_DEPENDS= ${PYTHON_LIBDIR}/lib-dynload/_sqlite3.so:${PORTSDIR}/databases/py-sqlite3 MYSQL_RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}MySQLdb>=1.2.3:${PORTSDIR}/databases/py-MySQLdb ... instead of the .if ${PORT_OPTIONS:...} conditionals. This also would make the .include <bsd.port.options.mk> line superfluous. - For stage-aware ports you do not need a .if ${PORT_OPTIONS:MDOCS} conditional. This is handled by the staging code, so you can always install the docs or examples into the staging area. We would appreciate it, if you could fix or change the aforementioned issues. Cheers Marcus Hello Marcus, thanks for your valuable feedback on my ports proposal. I'll work them in the next few days and attach a new patch to this PR. Please apologize the delay of my response - I did not notice the nofication E-Mail on time and found your reply at my periodic checks of my PRs. Best regards, Matthias -- Matthias Petermann <matthias@d2ux.org> | www.petermann-it.de GnuPG: 0x5C3E6D75 | 5930 86EF 7965 2BBA 6572 C3D7 7B1D A3C3 5C3E 6D75 Hello, attached is the new Shar archive. All proposed changes were incorporated. The version was updated to the latest 2.2.2. Thanks & best regards, Matthias -- Matthias Petermann <matthias@petermann-it.de> | www.petermann-it.de GnuPG: 0x5C3E6D75 | 5930 86EF 7965 2BBA 6572 C3D7 7B1D A3C3 5C3E 6D75 New port committed, thanks! |