Bug 185657

Summary: [patch] ports/multimedia/libvpx fails to build on i386 9-STABLE
Product: Ports & Packages Reporter: Helge Oldach <ports-libvpx-jan14>
Component: Individual Port(s)Assignee: Ashish SHUKLA <ashish>
Status: Closed FIXED    
Severity: Affects Only Me CC: ashish
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Helge Oldach 2014-01-11 11:50:00 UTC 
On a recent 9-STABLE machine (built on 7th January 2014):

# make -C /usr/ports/multimedia/libvpx
<---- snip ----->
cc  -O2 -pipe -fno-strict-aliasing -m32 -g -O3 -fPIC -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -Wdeclaration-after-statement -Wdisabled-optimization -Wpointer-arith -Wcast-qual -Wvla -Wimplicit-function-declaration -Wuninitialized -Wunused-variable -Wno-unused-function -I. -I"/usr/obj/usr/ports/multimedia/libvpx/work/libvpx-1.3.0" -msse2 -c -o vp9/common/x86/vp9_idct_intrin_sse2.c.o vp9/common/x86/vp9_idct_intrin_sse2.c
vp9/common/x86/vp9_idct_intrin_sse2.c: In function 'vp9_idct32x32_1024_add_sse2':
vp9/common/x86/vp9_idct_intrin_sse2.c:3636: note: use -flax-vector-conversions to permit conversions between vectors with differing element types or numbers of subparts
vp9/common/x86/vp9_idct_intrin_sse2.c:3636: error: incompatible type for argument 1 of '__builtin_ia32_psrlqi128'
gmake[1]: *** [vp9/common/x86/vp9_idct_intrin_sse2.c.o] Error 1
gmake[1]: *** Waiting for unfinished jobs....
gmake: *** [.DEFAULT] Error 2
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** [do-build] Error code 1

Stop in /usr/ports/multimedia/libvpx.
*** [build] Error code 1

Stop in /usr/ports/multimedia/libvpx.
#
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-01-11 11:50:09 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ashish

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Andrey A. Chernov freebsd_committer freebsd_triage 2014-01-12 11:02:36 UTC 
On 12.01.2014 14:19, Ashish SHUKLA wrote:
> Could you please try this attached diff for multimedia/libvpx on your 9-STABLE
> hosts, to see if it fixes the issue for you ?


It fixes the issue, thanx.
Comment 3 Helge Oldach 2014-01-12 11:59:14 UTC 
Hi Ashish,

yep, that fixes it.

Kind regards
Helge


Ashish SHUKLA wrote on Sun, 12 Jan 2014 11:19:28 +0100 (CET):
> Hi,
> 
> Could you please try this attached diff for multimedia/libvpx on your 9-STABLE
> hosts, to see if it fixes the issue for you ?
> 
> Thanks
> -- 
> Ashish SHUKLA      | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0
> Sent from my Emacs

[Attachment, skipping...]

[application/pgp-signature is not supported, skipping...]
Comment 4 dfilter service freebsd_committer freebsd_triage 2014-01-12 16:08:34 UTC 
Author: ashish
Date: Sun Jan 12 16:08:27 2014
New Revision: 339519
URL: http://svnweb.freebsd.org/changeset/ports/339519

Log:
  - Fix breakage on 9-STABLE due to GCC changes in r260075
  
  PR:		ports/185657
  Submitted by:	Helge Oldach <ports-libvpx-jan14 at oldach.net>

Modified:
  head/multimedia/libvpx/Makefile

Modified: head/multimedia/libvpx/Makefile
==============================================================================
--- head/multimedia/libvpx/Makefile	Sun Jan 12 16:03:49 2014	(r339518)
+++ head/multimedia/libvpx/Makefile	Sun Jan 12 16:08:27 2014	(r339519)
@@ -55,6 +55,12 @@ USE_GCC=	yes
 .endif
 .endif
 
+# Workaround for GCC in 9.x post r260075
+# OSVERSION taken from r260135, the closest OSVERSION
+.if ${OSVERSION} >  902505 && ${OSVERSION} < 1000000
+CFLAGS+=	-flax-vector-conversions
+.endif
+
 .if ${OSVERSION} >= 1000000
 CONFIGURE_ARGS+=	--disable-unit-tests
 .endif
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Ashish SHUKLA freebsd_committer freebsd_triage 2014-01-12 16:13:23 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!