Bug 18569

Summary:	tool source not installed
Product:	Base System	Reporter:	Jim.Pirzyk <Jim.Pirzyk>
Component:	conf	Assignee:	Jim Pirzyk <pirzyk>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	4.0-STABLE
Hardware:	Any
OS:	Any

Description Jim.Pirzyk 2000-05-15 17:00:00 UTC

 when running src/install.sh all, the tool source is not installed.

Fix: 

if [ "$1" = "all" ]; then
!       dists="base bin contrib etc games gnu include lib libexec release sbin share sys ubin usbin"
else
dists="$*"
fi
--- 16,22 ----
fi

if [ "$1" = "all" ]; then
!       dists="base bin contrib etc games gnu include lib libexec release sbin share sys tools ubin usbin"
else
dists="$*"
fi--WSpZSiAdKAE1schN1P7GQJ9srrrZzo2G3E9e5j7srIAfaNy3
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

*** install.sh.orig     Thu May 11 09:20:16 2000
--- install.sh  Thu May 11 09:17:51 2000
***************
*** 16,22 ****
fi
How-To-Repeat: 
 run src/install.sh all on a system that does not have src installed
 and see if src/tools then exists.

Comment 1 Jeroen Ruigrok/Asmodai 2000-05-15 20:04:13 UTC

-On [20000515 20:08], Jim Pirzyk (Jim.Pirzyk@disney.com) wrote:
>
> when running src/install.sh all, the tool source is not installed.

It might be me, but I thought the tools were not for general
installation?

-- 
Jeroen Ruigrok vd Werven/Asmodai    asmodai@[wxs.nl|bart.nl|freebsd.org]
Documentation nutter/C-rated Coder BSD: Technical excellence at its best  
The BSD Programmer's Documentation Project <http://home.wxs.nl/~asmodai>
Love conquers all...

Comment 2 Jim.Pirzyk 2000-05-15 20:57:48 UTC

On Mon, 15 May 2000, Jeroen Ruigrok/Asmodai wrote:
> -On [20000515 20:08], Jim Pirzyk (Jim.Pirzyk@disney.com) wrote:
> >
> > when running src/install.sh all, the tool source is not installed.
> 
> It might be me, but I thought the tools were not for general
> installation?

But you do need the tools source if you want to do a 'make world',
so either the install.sh script is wrong in the src directory or the
mk files are wrong for needing the src/tools/..... stuff.

- JimP

> 
> -- 
> Jeroen Ruigrok vd Werven/Asmodai    asmodai@[wxs.nl|bart.nl|freebsd.org]
> Documentation nutter/C-rated Coder BSD: Technical excellence at its best  
> The BSD Programmer's Documentation Project <http://home.wxs.nl/~asmodai>
> Love conquers all...
-- 
--- @(#) $Id: dot.signature,v 1.8 2000/03/20 16:32:13 pirzyk Exp $
    __o   Jim.Pirzyk@disney.com -------------------------------------
 _'\<,_   System Integrator, Walt Disney Feature Animation 
(*)/ (*)

Comment 3 DougB 2000-05-17 18:12:00 UTC

Jim Pirzyk wrote:

> > >  But you do need the tools source if you want to do a 'make world',

	I stand corrected. src/tools/install.sh is indeed called by
Makefile.inc1. My understanding is that the stuff in the tools directory
should never be mandatory, so Marcel, could you take a look at this? I
of course may be wrong about this too. :)

Doug

Comment 4 marcel 2000-05-17 20:29:51 UTC

Doug Barton wrote:

> > > >  But you do need the tools source if you want to do a 'make world',
> 
>         I stand corrected. src/tools/install.sh is indeed called by
> Makefile.inc1. My understanding is that the stuff in the tools directory
> should never be mandatory, so Marcel, could you take a look at this? I
> of course may be wrong about this too. :)

I don't know anything about the "non-mandatory status" of the tools
subdirectory. Can you give me a pointer?

The purpose of install.sh is to allow non-root builds. It only filters
some arguments that prevent non-root builds. You can therefore safely
override using install.sh by defining INSTALL in /etc/make.conf (eg:
INSTALL=/usr/bin/install). You may need to undefine it first, but I
haven't verified that...

HTH,

-- 
Marcel Moolenaar
  mail: marcel@cup.hp.com / marcel@FreeBSD.org
  tel:  (408) 447-4222

Comment 5 Jim Pirzyk freebsd_committer

2001-06-04 20:55:12 UTC

State Changed
From-To: open->closed

Closed since this was a specific release problem with src/tools not 
being included with the src tarballs.

Comment 6 Jim Pirzyk freebsd_committer

2001-06-04 20:55:12 UTC

Responsible Changed
From-To: freebsd-bugs->pirzyk

Picked up to close right away