Bug 185810

Summary:

[patch][porters-handbook]: add needed whitespace in Makefile for port

Product:

Documentation

Reporter:

Jason Helfman <jgh>

Component:

Books & Articles

Assignee:

Warren Block <wblock>

Status:

Closed FIXED

Severity:

Affects Only Me

Priority:

Normal

Version:

Latest

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
file.diff	none

Description Jason Helfman freebsd_committer

2014-01-15 19:50:00 UTC

Any new port, or port in the tree is going to need a extra line before inclusion
of bsd.port.mk, so let's give committers and contributors less work by adding this
to documentation.

This passed building and testing successfully.

Comment 1 Warren Block freebsd_committer

2014-01-15 20:05:02 UTC

Responsible Changed
From-To: freebsd-doc->wblock

Take.

Comment 2 dfilter service freebsd_committer

2014-01-15 20:21:26 UTC

Author: wblock
Date: Wed Jan 15 20:21:18 2014
New Revision: 43544
URL: http://svnweb.freebsd.org/changeset/doc/43544

Log:
  Add blank lines to delimit .include statements in Makefiles.
  
  PR:		docs/185810
  Submitted by:	Jason Helfman <jgh@FreeBSD.org>

Modified:
  head/en_US.ISO8859-1/books/porters-handbook/book.xml

Modified: head/en_US.ISO8859-1/books/porters-handbook/book.xml
==============================================================================
--- head/en_US.ISO8859-1/books/porters-handbook/book.xml	Wed Jan 15 19:46:36 2014	(r43543)
+++ head/en_US.ISO8859-1/books/porters-handbook/book.xml	Wed Jan 15 20:21:18 2014	(r43544)
@@ -156,6 +156,7 @@ MASTER_SITES=	ftp://ftp.cs.columbia.edu/
 
 MAINTAINER=	youremail@example.com
 COMMENT=	Cat chasing a mouse all over the screen
+
 .include &lt;bsd.port.mk&gt;</programlisting>
 
       <note>
@@ -4718,7 +4719,9 @@ OPT1_CONFIGURE_OFF=	--no-test</programli
 	<para>is equivalent to:</para>
 
 	<programlisting>OPTIONS_DEFINE=	OPT1
+
 .include &lt;bsd.port.options.mk&gt;
+
 .if ! ${PORT_OPTIONS:MOPT1}
 CONFIGURE_ARGS+=	--no-test
 .endif</programlisting>
@@ -12477,6 +12480,7 @@ pre-install:
 	and then some more stuff before installing, wow
 
 [and then the epilogue]
+
 .include &lt;bsd.port.mk&gt;</programlisting>
   </chapter>
 
_______________________________________________
svn-doc-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-doc-all
To unsubscribe, send any mail to "svn-doc-all-unsubscribe@freebsd.org"

Comment 3 Warren Block freebsd_committer

2014-01-15 20:21:29 UTC

State Changed
From-To: open->closed

Embiggened patch committed, thanks!