Bug 185906
| Summary: | databases/slony1v2 -- fix build with poudriere and non-default postgresql version, etc | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Matthew Seaman <matthew> | ||||||
| Component: | Individual Port(s) | Assignee: | Jimmy Olgeni <olgeni> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | robak | ||||||
| Priority: | Normal | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Responsible Changed From-To: freebsd-ports-bugs->olgeni Over to maintainer (via the GNATS Auto Assign Tool) The patch fails to apply cleanly to the current port version, could you please update it and submit again so I could review, test and commit it? Created attachment 155224 [details]
Updated patch
As requested, update the patch for a current ports tree.
Most of the changes had already been applied. The remaining bits are:
* Use OPTIONS helpers for the PERLTOOLS option
* Remove a redundant block of code for setting PGSQL_VER: this
functionality is already supplied via 'USES+= pgsql'
Cheers,
Matthew
A commit references this bug: Author: robak Date: Tue Apr 7 21:58:57 UTC 2015 New revision: 383543 URL: https://svnweb.freebsd.org/changeset/ports/383543 Log: databases/slony1v2: port cleanup - Use OPTIONS helpers for the PERLTOOLS option - Remove a redundant block of code for setting PGSQL_VER: this functionality is already supplied via 'USES+= pgsql' - Maintainer's timeout (olgeni@FreeBSD.org) PR: 185906 Submitted by: Matthew Seaman <matthew@FreeBSD.org> Changes: head/databases/slony1v2/Makefile Committed, thanks for your work! |
How-To-Repeat: Update the port to use various more recent constructs, with the benefit that it makes it possible to build a pkg against a non-default postgresql version using poudriere * USES=pgsql -- use the standard ports methods for deciding what postgresql version to compile against, instead of DiY code * while here, OPTIONS helpers * Pass ${PERL} through to configure to prevent 'make stage-qa' complaining about files that need to be shebangfixed. * USES=shebangfix for the one perl script that doesn't get its #! line set correctly by the above during the build process There are still a number of warnings about unstripped binaries generated with DEVELOPER=yes in /etc/make.conf which I haven't fixed here.