Bug 18608

Summary: davicom PNP modem not recognized
Product: Base System Reporter: martijn <martijn>
Component: kernAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.0-RELEASE   
Hardware: Any   
OS: Any   

Description martijn 2000-05-16 21:40:04 UTC
My davicom PNP internal modem card is not detected because the
PNP signature is not listed in sys/isa/sio.c.

After adding the signature the modem card is recognised, a sio
device is attached and I can access the modem.

I propose to add the signature.

Fix: Here is my diff -c -r:



This is a diff against this file version:

 * $FreeBSD: src/sys/isa/sio.c,v 1.291.2.2 2000/05/02 06:05:50 tanimura Exp $
 *	from: @(#)com.c	7.5 (Berkeley) 5/16/91
 *	from: i386/isa sio.c,v 1.234--9l9Vd2GEtWvgb9fnvZdLQxpkl8o1YORv0teZC3ZWVK3jKq3U
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

*** /sys/isa/sio.c	Tue May  2 08:05:50 2000
--- /sys/isa/sio-davicom.c	Tue May 16 21:49:13 2000
***************
*** 559,564 ****
--- 559,565 ----
  	{0x00b4490a, NULL},	/* BRIB400 - Boca 56k PnP */
  	{0x0030320d, NULL},	/* CIR3000 - Cirrus Logic V43 */
  	{0x0100440e, NULL},	/* CRD0001 - Cardinal MVP288IV ? */
+ 	(0x36033610, NULL),     /* DAV0336 - DAVICOM 336PNP MODEM */
  	{0x0000aa1a, NULL},	/* FUJ0000 - FUJITSU Modem 33600 PNP/I2 */
  	{0x1200c31e, NULL},	/* GVC0012 - VF1128HV-R9 (win modem?) */
  	{0x0303c31e, NULL},	/* GVC0303 - MaxTech 33.6 PnP D/F/V */
How-To-Repeat: 
n/a
Comment 1 martijn 2000-05-17 19:22:24 UTC
Oops.. shame on me.

While double-checking my change request kern/18608 I saw I diffed the wrong
file. There's a slight syntax error in that it uses ('s instead of {'s.

martijn
Comment 2 tanimura freebsd_committer freebsd_triage 2000-05-18 03:15:55 UTC
State Changed
From-To: open->closed

Fixed in rev 1.297(HEAD) and 1.291.2.3(RELENG_4), thanks!