Bug 186088
| Summary: | [PATCH] devel/py27-dateutil: fix non-root build, other updates | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John Hein <jhein> | ||||||
| Component: | Individual Port(s) | Assignee: | Nicola Vitale <nivit> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | nivit | ||||||
| Priority: | Normal | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Responsible Changed From-To: freebsd-ports-bugs->nivit Over to maintainer (via the GNATS Auto Assign Tool) Updated patch to remove egg-info stuff from pkg-plist as it is automatically added when using USE_PYDISTUTILS=yes. Author: antoine Date: Mon Feb 10 19:04:09 2014 New Revision: 343673 URL: http://svnweb.freebsd.org/changeset/ports/343673 QAT: https://qat.redports.org/buildarchive/r343673/ Log: - Add LICENSE - Switch from easy_install to install - Allow packaging as a regular user - Use PYDISTUTILS_AUTOPLIST - Stage support PR: ports/186088 PR: ports/186092 Submitted by: John Hein and Johannes Jost Meixner Approved by: maintainer timout (2 weeks) Deleted: head/devel/py-dateutil/pkg-plist Modified: head/devel/py-dateutil/Makefile Modified: head/devel/py-dateutil/Makefile ============================================================================== --- head/devel/py-dateutil/Makefile Mon Feb 10 18:44:40 2014 (r343672) +++ head/devel/py-dateutil/Makefile Mon Feb 10 19:04:09 2014 (r343673) @@ -3,7 +3,7 @@ PORTNAME= dateutil PORTVERSION= 2.1 -PORTREVISION= 2 +PORTREVISION= 3 CATEGORIES= devel python MASTER_SITES= CHEESESHOP PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} @@ -12,19 +12,18 @@ DISTNAME= python-dateutil-${PORTVERSION} MAINTAINER= nivit@FreeBSD.org COMMENT= Provides powerful extensions to the standard datetime module -LICENSE= BSD +LICENSE= BSD3CLAUSE BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}six>0:${PORTSDIR}/devel/py-six RUN_DEPENDS+= ${BUILD_DEPENDS} USE_PYTHON= yes -USE_PYDISTUTILS= easy_install -PYDISTUTILS_PKGNAME= python-dateutil +USE_PYDISTUTILS= yes +PYDISTUTILS_AUTOPLIST= yes # Fix incorrect permissions -NO_STAGE= yes post-patch: - @${FIND} ${WRKSRC} -type f -exec ${CHMOD} ${SHAREMODE} {} ";" + @${FIND} ${WRKSRC} -type f -exec ${CHMOD} 644 {} ";" @${REINPLACE_CMD} -e 's|import winreg|from six.moves import winreg|' ${WRKSRC}/dateutil/tzwin.py regression-test: build _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org" State Changed From-To: open->closed Patch committed, thanks! |
The main motivation for this patch is to fix the build for the non-root user. The chmod in post-patch was removing write permission from files that the build is trying to write to. Okay if you're root on a local filesystem, but it fails if you are a regular user (try just 'make' as a regular user) because setup.py tries to write to files in the python_dateutil.egg-info (which are now read-only thanks to the chmod 444 in post-patch). The fix is to change ${SHAREMODE} (0444) to a+r for the chmod. While I was here, I: - added support for staging - moved away from the deprecated easy_install (changes plist, thus bumped PORTREVISION as well) - replaced the deprecated BSD license with BSD3CLAUSE I chose to still use the static pkg-plist rather than use PYDISTUTILS_AUTOPLIST. p.s. bsd.python.mk could probably add PYDISTUTILS_EGGINFO to PLIST_SUB. Port maintainer (nivit@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: SVN) How-To-Repeat: As a regular user: cd /usr/ports/devel/py-dateutil make Observe: . . running egg_info writing requirements to python_dateutil.egg-info/requires.txt error: python_dateutil.egg-info/requires.txt: Permission denied