Bug 186148

Summary: www/shellinabox : staging and cleanup patch
Product: Ports & Packages Reporter: olivier
Component: Individual Port(s)Assignee: Alex Kozlov <ak>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
patch.txt none

Description olivier 2014-01-27 00:10:00 UTC 
Here is a cleanup regarding this port:
 - staging
 - remove useless DOCs

Fix: Patch attached with submission follows:
Comment 1 Alex Kozlov 2014-01-27 06:53:09 UTC 
Hi

Can you please review the attached patch?
Thanks.


-- 
Alex
Comment 2 olivier 2014-01-27 07:39:41 UTC 
On Mon, Jan 27, 2014 at 7:53 AM, Alex Kozlov <spam@rm-rf.kiev.ua> wrote:

> Hi
>
> Can you please review the attached patch?
> Thanks.
>
> Hi Alex,
did you modify it ? (because I'm the author of this "maintainer-update" PR).

Regards,

Olivier
Comment 3 Alex Kozlov 2014-01-27 07:57:43 UTC 
On Mon, Jan 27, 2014 at 08:39:41AM +0100, Olivier Cochard-Labbé wrote:
> On Mon, Jan 27, 2014 at 7:53 AM, Alex Kozlov <spam@rm-rf.kiev.ua> wrote:
> > Can you please review the attached patch?
> > Thanks.
> >
> > Hi Alex,
> did you modify it ? (because I'm the author of this "maintainer-update" PR).
Yes, I've fixed mode in plist: http://redports.org/~ak0/20140127060301-21904-172399/shellinabox-2.14_3.log ,
wrap overly long lines and removed whitespaces at eol in pkg-descr,
used options helpers to simplify port and also make a few cosmetic changes.


-- 
Alex
Comment 4 olivier 2014-01-27 08:15:28 UTC 
On Mon, Jan 27, 2014 at 8:57 AM, Alex Kozlov <spam@rm-rf.kiev.ua> wrote:

>
> Yes, I've fixed mode in plist:
> http://redports.org/~ak0/20140127060301-21904-172399/shellinabox-2.14_3.log,
> wrap overly long lines and removed whitespaces at eol in pkg-descr,
> used options helpers to simplify port and also make a few cosmetic changes.
>

great: Then it's okay.

Thanks,

Olivier
Comment 5 Alex Kozlov freebsd_committer freebsd_triage 2014-01-27 08:22:49 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ak

I'll take it.
Comment 6 Alex Kozlov freebsd_committer freebsd_triage 2014-01-27 08:23:06 UTC 
State Changed
From-To: open->closed

Committed. Thanks!