Bug 186502

Summary: www/davical fails with Mac OS X 10.9's Contacts.app
Product: Ports & Packages Reporter: Niels Bakker <niels=freebsd>
Component: Individual Port(s)Assignee: John Marino <marino>
Status: Closed FIXED    
Severity: Affects Only Me CC: marino, maurice
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 187112    
Bug Blocks:    
Attachments:
Description Flags
davical.patch none

Description Niels Bakker 2014-02-06 00:40:01 UTC 
Contacts.app cannot add new Vcards to a DAViCal server. Applying the patch makes this work and appears to have no side effects.
Please include the patch in the port until a new upstream release has become available.

Fix: 

https://github.com/DAViCal/davical/commit/03c34598e60f4766fb3bda492d7b4f9dc04cd54b
How-To-Repeat: You need a Mac running 10.9 or 10.9.1. See here for more testimonials of the problem:
http://sourceforge.net/mailarchive/message.php?msg_id=31607165
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-02-06 04:37:53 UTC 
Maintainer of www/davical,

Please note that PR ports/186502 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/186502

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-02-06 04:37:54 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 maurice 2014-02-07 03:40:10 UTC 
Created minimal patch that should fix the Maverick problem until there is a new release. Only preliminarily tested.

Maurice Castro
Comment 4 Niels Bakker 2014-02-07 12:03:33 UTC 
Hi,

Thanks!

The error_log() invocation can be removed for non-debugging builds.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-07-11 15:16:25 UTC 
Add maintainer back to PR
Comment 6 John Marino freebsd_committer freebsd_triage 2014-07-27 00:15:28 UTC 
The attached patch is useless:

> EXTRA_PATCHES+=	${FILESDIR}/maverick-fix.patch


But there's no such patch in files, and the diff doesn't create it.

Sending back to submitter/maintainer
Comment 7 John Marino freebsd_committer freebsd_triage 2014-10-06 06:24:17 UTC 
Okay, so here is the latest:

1) The maintainer has been reset per request
2) attachment 140051 [details] is actually complete.  The bugzilla diffviewer bug was unknown by me at the time and it looked this it was truncated.  The diff viewer shows the extra patch now
3) I don't see why this is an "extra" patch which is normally only conditionally applied.  This patch needs applying all the time, so it should be a regular patch and the port should be bumped.

Moving to patch-ready with instructions:

1) Rename the patch so it always applies
2) Don't set EXTRA_PATCHES in Makefile
3) revbump the port.
Comment 8 John Marino freebsd_committer freebsd_triage 2014-10-06 06:27:37 UTC 
Actually, let's set this to depend on bug 187112.  There's no sense in revbumping the port when it's got a known issue documented there.
Comment 9 commit-hook freebsd_committer freebsd_triage 2014-10-31 15:43:32 UTC 
A commit references this bug:

Author: marino
Date: Fri Oct 31 15:43:27 UTC 2014
New revision: 371860
URL: https://svnweb.freebsd.org/changeset/ports/371860

Log:
  www/davical: Reorganize port to fix DOCS option, Fix Mac OS contacts.app

  The DOCS option dumped the critical dba directory along with non-docs
  directories scripts and config into DOCSDIR, which resulted in a broken
  port if the user turned off the DOCS option.

  Reorganize the port to put dba and scripts in DATADIR, and config in
  EXAMPLESDIR and add the EXAMPLES option.  While here, use the @sample
  keyword, clean up @dirrm, and tweak a bit.

  The second PR fixes vcards on DAVICal servers for Mac OS 10.9.

  PR:		187112
  PR:		186502

Changes:
  head/www/davical/Makefile
  head/www/davical/files/patch-htdocs_caldav.php
  head/www/davical/files/pkg-message.in
  head/www/davical/pkg-plist