Bug 18659

Summary: devel/libol port ignores CC/CFLAGS for some files
Product: Ports & Packages Reporter: root <root>
Component: Individual Port(s)Assignee: freebsd-ports (Nobody) <ports>
Status: Closed FIXED    
Severity: Affects Only Me CC: vince
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description root 2000-05-18 17:20:00 UTC 
	See synopsis. For the files in the src subdirectory, CFLAGS
	appear as ``-O2 -Wall'' from nowhere. Strange, because configure
	seems to set them properly.

Fix: In any case, the following should be put into patches/patch-aa
Comment 1 Maxim Sobolev freebsd_committer freebsd_triage 2000-05-19 11:48:44 UTC 
State Changed
From-To: open->closed

Proplem solved, though I have to generate my own patch. Thanks for reporting!
Comment 2 Mikhail Teterin 2000-05-19 16:39:22 UTC 
On 18 May, Vince Valenti wrote:
= On Thu, 18 May 2000, Will Andrews wrote:
= 
= > On Thu, May 18, 2000 at 05:30:01PM -0700, Will Andrews wrote:
= > > +	CFLAGS="${CFLAGS} -Wall $LIBOL_CFLAGS -D_GNU_SOURCE"
= > 
= > Actually,  doesn't this  sort  of thing  result  in make(1)  spewing
= > something like "recursive variable CFLAGS"  or similar? This may not
= > be the  best way to  implement enforced CFLAGS. You  probably should
= > have  something like  ${PCFLAGS} here  instead, and  define PCFLAGS=
= > ${CFLAGS} in the port Makefile.
=
= It seemed to work  when I ran the suggested patch...  I'd say go ahead
= and commit it. If it would be better to have a PCFLAGS variable, I can
= whip up a patch for that if you'd like.

The  same problem  exists for  the devel/libol  (see ports/18659).  That
software comes  from the  author, with  the same  bug in  the configure.
Please, consider the same patch (line numbers may be different) :)

	-mi