Bug 186608

Summary: typo in 'ctime(3) man page
Product: Documentation Reporter: Jamie Landeg-Jones <jamie>
Component: Books & ArticlesAssignee: Gavin Atkinson <gavin>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Jamie Landeg-Jones 2014-02-09 22:20:00 UTC
Another typo. This time in ctime.3 man page..  I realise this is in 'contrib' but there doesn't seem to be any info regarding who this is pulled from.

I hope I don't get the reputation for most anal contributor :-(

(Is a PR the best way to report something so insignificant? Seems like overkill... Gimme doc commit access!)

Anyway.... The word 'leaves' instead of 'leave' in the following line:

"-these functions leaves their result in an internal static object and return"

cheers, Jamie

Fix: apply patch (!)

	
How-To-Repeat: 
man 3 ctime
Comment 1 Benjamin Kaduk freebsd_committer freebsd_triage 2014-02-10 19:54:16 UTC
On Sun, 9 Feb 2014, Jamie Landeg-Jones wrote:

>
>> Description:
>
> Another typo. This time in ctime.3 man page..  I realise this is in 
> 'contrib' but there doesn't seem to be any info regarding who this is 
> pulled from.

I think that the current ~upstream for the tzcode is supposed to be 
https://github.com/eggert/tz/ , but I haven't checked particularly 
recently.  (There was some excitement involving a legal action, etc., so 
it had gone away and/or moved.)  That said, I don't see a BUGS section at 
all in the newctime.3 in that repo, and I also don't see the erroneous 
line you quote in the history of that repo, so ... I'm not sure what 
happened.

> I hope I don't get the reputation for most anal contributor :-(

Definitely not!

> (Is a PR the best way to report something so insignificant? Seems like 
> overkill... Gimme doc commit access!)

PR is fine, it gives us a place to look when we need to find things.

> Anyway.... The word 'leaves' instead of 'leave' in the following line:
>
> "-these functions leaves their result in an internal static object and return"

Thanks for pointing it out.  I'll try to think about what the best route 
to a fix is.

-Ben
Comment 2 Jamie Landeg-Jones 2014-02-13 09:16:13 UTC
Benjamin Kaduk <bjk@freebsd.org> wrote:

> I think that the current ~upstream for the tzcode is supposed to be 
> https://github.com/eggert/tz/ , but I haven't checked particularly 
> recently.  (There was some excitement involving a legal action, etc., so 
> it had gone away and/or moved.)  That said, I don't see a BUGS section at 
> all in the newctime.3 in that repo, and I also don't see the erroneous 
> line you quote in the history of that repo, so ... I'm not sure what 
> happened.

Ahh. OK! Thanks.

> > I hope I don't get the reputation for most anal contributor :-(
>
> Definitely not!

ha! You haven't seen my other PR's :-)

> PR is fine, it gives us a place to look when we need to find things.

ok, thanks.

> Thanks for pointing it out.  I'll try to think about what the best route 
> to a fix is.

no rush. hee hee.

p.s. my next PRs (2 pending) are 'proper' bug fixes!

cheers, Jamie
Comment 3 dfilter service freebsd_committer freebsd_triage 2014-05-15 04:08:26 UTC
Author: gavin
Date: Thu May 15 03:08:20 2014
New Revision: 266111
URL: http://svnweb.freebsd.org/changeset/base/266111

Log:
  Fix typo.  Note that although this file is under contrib, it has diverged
  sufficiently from upstream (including a full whitespace commit and large
  portions rewritten) that this change does not move us further from the
  upstream.
  
  PR:		docs/186608
  Submitted by:	Jamie Landeg-Jones <jamie@dyslexicfish.net>
  MFC after:	3 days

Modified:
  head/contrib/tzcode/stdtime/ctime.3

Modified: head/contrib/tzcode/stdtime/ctime.3
==============================================================================
--- head/contrib/tzcode/stdtime/ctime.3	Thu May 15 02:41:23 2014	(r266110)
+++ head/contrib/tzcode/stdtime/ctime.3	Thu May 15 03:08:20 2014	(r266111)
@@ -342,7 +342,7 @@ Except for
 and the
 .Fn \&_r
 variants of the other functions,
-these functions leaves their result in an internal static object and return
+these functions leave their result in an internal static object and return
 a pointer to that object.
 Subsequent calls to these
 function will modify the same object.
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 4 Gavin Atkinson freebsd_committer freebsd_triage 2014-05-15 04:08:28 UTC
State Changed
From-To: open->patched

Patched in head, will merge in three days. 


Comment 5 Gavin Atkinson freebsd_committer freebsd_triage 2014-05-15 04:08:28 UTC
Responsible Changed
From-To: freebsd-doc->gavin

Patched in head, will merge in three days.
Comment 6 dfilter service freebsd_committer freebsd_triage 2014-05-22 21:56:00 UTC
Author: gavin
Date: Thu May 22 20:55:57 2014
New Revision: 266557
URL: http://svnweb.freebsd.org/changeset/base/266557

Log:
  Merge r266111 from head:
  
    Fix typo.  Note that although this file is under contrib, it has diverged
    sufficiently from upstream (including a full whitespace commit and large
    portions rewritten) that this change does not move us further from the
    upstream.
  
  PR:		docs/186608
  Submitted by:	Jamie Landeg-Jones <jamie@dyslexicfish.net>

Modified:
  stable/10/contrib/tzcode/stdtime/ctime.3
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/contrib/tzcode/stdtime/ctime.3
==============================================================================
--- stable/10/contrib/tzcode/stdtime/ctime.3	Thu May 22 20:24:30 2014	(r266556)
+++ stable/10/contrib/tzcode/stdtime/ctime.3	Thu May 22 20:55:57 2014	(r266557)
@@ -342,7 +342,7 @@ Except for
 and the
 .Fn \&_r
 variants of the other functions,
-these functions leaves their result in an internal static object and return
+these functions leave their result in an internal static object and return
 a pointer to that object.
 Subsequent calls to these
 function will modify the same object.
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 7 dfilter service freebsd_committer freebsd_triage 2014-05-22 21:59:43 UTC
Author: gavin
Date: Thu May 22 20:59:38 2014
New Revision: 266558
URL: http://svnweb.freebsd.org/changeset/base/266558

Log:
  Merge r266111 from head:
  
    Fix typo.  Note that although this file is under contrib, it has diverged
    sufficiently from upstream (including a full whitespace commit and large
    portions rewritten) that this change does not move us further from the
    upstream.
  
  PR:		docs/186608
  Submitted by:	Jamie Landeg-Jones <jamie@dyslexicfish.net>

Modified:
  stable/9/contrib/tzcode/stdtime/ctime.3
Directory Properties:
  stable/9/contrib/tzcode/stdtime/   (props changed)

Modified: stable/9/contrib/tzcode/stdtime/ctime.3
==============================================================================
--- stable/9/contrib/tzcode/stdtime/ctime.3	Thu May 22 20:55:57 2014	(r266557)
+++ stable/9/contrib/tzcode/stdtime/ctime.3	Thu May 22 20:59:38 2014	(r266558)
@@ -342,7 +342,7 @@ Except for
 and the
 .Fn \&_r
 variants of the other functions,
-these functions leaves their result in an internal static object and return
+these functions leave their result in an internal static object and return
 a pointer to that object.
 Subsequent calls to these
 function will modify the same object.
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 8 Gavin Atkinson freebsd_committer freebsd_triage 2014-05-22 22:00:04 UTC
State Changed
From-To: patched->closed

Merged to stable/10 and stable/9.