Bug 18688

Summary: libfetch: Restart does not work in active FTP mode (r.: des)
Product: Base System Reporter: cejkar <cejkar>
Component: binAssignee: Dag-Erling Smørgrav <des>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.0-CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description cejkar 2000-05-20 08:20:01 UTC 
In libfetch, there is restart capability (data downloading with begin
somewhere in the middle of the file) for HTTP and passive FTP
mode. But when active FTP mode is used, restart does not work.

It is because lines performing REST command were added only to
passive FTP mode section, whereas in active FTP mode these lines
are missing.

Fix: Hmm. It looks that branching in lib/libfetch/ftp.c,v is broken:

# co lib/libfetch/ftp.c,v
lib/libfetch/ftp.c,v  -->  ftp.c
revision 1.20
done

But retrieved file is revision 1.19:

$FreeBSD: src/lib/libfetch/ftp.c,v 1.19 2000/05/15 08:24:58 des Exp $

Here is simple patch adding restart capability to active ftp mode:
Comment 1 Dag-Erling Smørgrav freebsd_committer freebsd_triage 2000-06-29 11:44:19 UTC 
State Changed
From-To: open->feedback

Patch applied to -CURRENT, thanks!
Comment 2 Dag-Erling Smørgrav freebsd_committer freebsd_triage 2000-06-29 11:44:19 UTC 
Responsible Changed
From-To: freebsd-bugs->des

libfetch is mine.
Comment 3 Dag-Erling Smørgrav freebsd_committer freebsd_triage 2000-07-19 10:27:02 UTC 
State Changed
From-To: feedback->closed

Fixed in -CURRENT and -STABLE, thanks!