Bug 187282

Summary: lang/clisp fails to compile
Product: Ports & Packages Reporter: Robert Cina <robcina>
Component: Individual Port(s)Assignee: John Marino <marino>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Robert Cina 2014-03-05 14:20:00 UTC 
Port of clisp fails to compile.

.o  built.o modules.o /usr/local/lib/libintl.so -Wl,-rpath -Wl,/usr/local/lib /usr/local/lib/libreadline.so -Wl,-rpath -Wl,/usr/local/lib -lncurses /usr/local/lib/libavcall.a /usr/local/lib/libcallback.a  -L/usr/local/lib -lsigsegv -R/usr/local/lib libgnu_cl.a -o lisp.run
stream.o: In function `oconv_unshift_output_buffered_':
stream.c:(.text+0xa1b2): undefined reference to `libiconv'
stream.o: In function `oconv_unshift_output_unbuffered_':
stream.c:(.text+0xa3d0): undefined reference to `libiconv'
stream.o: In function `iconv_mbstowcs':
stream.c:(.text+0xab7c): undefined reference to `libiconv'
stream.c:(.text+0xacc8): undefined reference to `libiconv'
stream.o: In function `iconv_mblen':
stream.c:(.text+0xafe9): undefined reference to `libiconv'
stream.o:stream.c:(.text+0xd0b7): more undefined references to `libiconv' follow
collect2: ld returned 1 exit status
*** Error code 1

Stop.
make[2]: stopped in /tmp/build/usr/ports/lang/clisp/work/clisp-2.49/src
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/lang/clisp
*** Error code 1

How-To-Repeat: cd /usr/ports/lang/clisp
make install clean
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-05 14:20:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jsa

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 rob.cina 2014-03-11 00:27:15 UTC 
Got clisp to compile and install by doing the following::

make CFLAGS=-liconv

make install
Comment 3 Mamoru IWAKI 2014-04-05 15:04:29 UTC 
Setting CFLAGS=-liconv worked good for me too.  Similary, Makefile.local
with the following line also works good for me.

LDFLAGS+=	-liconv

And the relevant iconv library looks resolved as expected.

> ldd /usr/local/bin/clisp
/usr/local/bin/clisp:
        libiconv.so.3 => /usr/local/lib/libiconv.so.3 (0x80081d000)
        libc.so.7 => /lib/libc.so.7 (0x800b17000)
>

So, simply adding the above LDFLAGS line in Makefile should solve the
problem as workaround for the present.
--
-----
Mamoru Iwaki
Japan
Comment 4 John Marino freebsd_committer freebsd_triage 2014-05-29 08:58:20 UTC 
Responsible Changed
From-To: jsa->marino

I'll take it.
Comment 5 freebsd.contact 2014-05-29 09:10:00 UTC 
What's going on is a dependency brought in ports iconv and and clisp
wants to build with the base iconv.

Thus ldd /usr/local/bin/clisp is not showing the right thing, it's
linked to ports libiconv instead of libc.

It appears iconv can be specified by configure (or turned off
completely) so that is the likely fix.

John
Comment 6 dfilter service freebsd_committer freebsd_triage 2014-05-29 10:07:25 UTC 
Author: marino
Date: Thu May 29 09:07:21 2014
New Revision: 355678
URL: http://svnweb.freebsd.org/changeset/ports/355678
QAT: https://qat.redports.org/buildarchive/r355678/

Log:
  lang/clisp: Unbreak by specifying proper iconv
  
  Adding a configure argument for libiconv make clisps build with either
  libc or libiconv as appropriate.  Fix verified on Redports on all supported
  platforms.
  
  PR:		ports/187282
  Submitted by:	Robert Cina
  Fixed by:	marino
  Approved by:	maintainer timeout (due to impending death of port)
  Approved by:	portmgr (implicit)
  
  Note that this port is still going to die in a few weeks, so I am not
  bothering to stage it.

Modified:
  head/lang/clisp/Makefile

Modified: head/lang/clisp/Makefile
==============================================================================
--- head/lang/clisp/Makefile	Thu May 29 08:36:51 2014	(r355677)
+++ head/lang/clisp/Makefile	Thu May 29 09:07:21 2014	(r355678)
@@ -3,12 +3,12 @@
 
 PORTNAME=	clisp
 PORTVERSION=	2.49
-PORTREVISION=	5
+PORTREVISION=	6
 CATEGORIES=	lang lisp
 MASTER_SITES=	GNU/${PORTNAME}/release/${PORTVERSION}
 
 MAINTAINER=	ports@FreeBSD.org
-COMMENT=	A Common Lisp implementation
+COMMENT=	Common Lisp implementation
 
 LICENSE=	GPLv2
 LICENSE_FILE=	${WRKSRC}/GNU-GPL
@@ -28,7 +28,7 @@ WANT_GNOME=	yes
 HAS_CONFIGURE=	yes
 CONFIGURE_ARGS=	--prefix="${PREFIX}" --mandir="${MANPREFIX}/man" \
 		--elispdir="${DATADIR}/emacs" --vimdir="${DATADIR}/vim" \
-		--docdir="${DOCSDIR}"
+		--docdir="${DOCSDIR}" --with-libiconv=${ICONV_PREFIX}
 CONFIGURE_TARGET=	${ARCH:S/amd64/x86_64/}-portbld-freebsd${OSREL}
 # Complaints if the environment changes between build stages.
 MAKE_ENV=	${CONFIGURE_ENV}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 John Marino freebsd_committer freebsd_triage 2014-05-29 10:12:10 UTC 
State Changed
From-To: open->closed

Fixed