Bug 187379

Summary: Attempting to buildworld to 10-STABLE from 9.2-STABLE blows up if `ORGANIZATION` defined in the environment when building svn[lite]
Product: Base System Reporter: Karl Denninger <karl>
Component: miscAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: bdrewery, emaste, ngie
Priority: Normal    
Version: 9.2-STABLE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Karl Denninger 2014-03-08 17:30:00 UTC
	With "ORGANIZATION" defined (as above) in the environment build blows 
	up in subversion.  The offending file appears to be
	/usr/src/usr.bin/svn/svn/Makefile, which echoes the variable into an
	include file without quotes around the string literal; said define
	is then used in the source without being quoted.

Fix: [root@NewFS /usr/src/usr.bin/svn/svn]# diff -c Makefile.orig Makefile
How-To-Repeat: 	Define "ORGANIZATION" in your environment on a checked-out copy of
	10-STABLE's source and type "make buildworld"
Comment 1 Bryan Drewery freebsd_committer freebsd_triage 2015-10-21 20:08:11 UTC
Fixed already in:

r278607 | gjb | 2015-02-11 16:17:14 -0800 (Wed, 11 Feb 2015) | 9 lines

Reduce number of lines to set ORGANIZATION_NAME in
freebsd-organization.h.

Patched by:     ian
PR:             197540
MFC after:      3 days
X-MFC-with:     r278603
Sponsored by:   The FreeBSD Foundation