Bug 187402

Summary: [maintainer-update] textproc/py-wtforms update to 1.0.5
Product: Ports & Packages Reporter: moggie
Component: Individual Port(s)Assignee: Kubilay Kocak <koobs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
py-wtforms-1.0.5.diff none

Description moggie 2014-03-09 20:40:00 UTC
- Update WTForms to version 1.0.5
- Change PORTNAME to lower case.
Comment 1 Edwin Groothuis freebsd_committer 2014-03-09 20:40:27 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-python

freebsd-python@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2014-04-23 03:16:31 UTC
Responsible Changed
From-To: freebsd-python->koobs

I'll take it.
Comment 3 commit-hook freebsd_committer 2014-06-08 12:06:16 UTC
A commit references this bug:

Author: koobs
Date: Sun Jun  8 12:05:29 UTC 2014
New revision: 357005
URL: http://svnweb.freebsd.org/changeset/ports/357005

Log:
  textproc/py-WTForms: Update to 1.0.5, lowercase PORTNAME

  - Update WTForms to version 1.0.5
  - Change PORTNAME to lower case.
  - Update LICENSE (BSD3CLAUSE)
  - pkg-descr: Tab to space in WWW:

  While I'm here:

  - Whitespace alignment
  - Tweak COMMENT
  - Re-order top section (portlint)

  PR:		187402
  Submitted by:	moggie at elasticmind dot net

Changes:
  head/textproc/py-wtforms/Makefile
  head/textproc/py-wtforms/distinfo
  head/textproc/py-wtforms/pkg-descr
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2014-06-08 12:08:07 UTC
Hi Moggie, thanks for your submission!

Here's a review below to help you with future contributions:

* Fatal portlint warnings:

FATAL: Makefile: MASTER_SITES appears out-of-order.
FATAL: Makefile: order must be PORTNAME/PORTVERSION/DISTVERSIONPREFIX/DISTVERSION/DISTVERSIONSUFFIX/PORTREVISION/PORTEPOCH/CATEGORIES/MASTER_SITES/MASTER_SITE_SUBDIR/PROJECTHOST/PKGNAMEPREFIX/PKGNAMESUFFIX/DISTNAME/EXTRACT_SUFX/DISTFILES/DIST_SUBDIR/EXTRACT_ONLY.

* pkg-descr patch replaced space with tab, not the other way around as expected (reversed patch?)

* DISTVERSIONPREFIX/DISTVERSIONSUFFIX not strictly necessary

* LICENSE must not contain BSD, instead use BSD[234]CLAUSE

Tip: Put DEVELOPER=yes into /etc/make.conf to enable Port Developer QA warnings