Bug 187656

Summary: Rename request of converters/igbinary
Product: Ports & Packages Reporter: Daniel Ylitalo <daniel>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: marino, robak
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
converters-igbinary.diff none

Description Daniel Ylitalo 2014-03-17 11:50:00 UTC
All php pecl modules (or most of them atleast) are prefixed with pecl-

I suggest renaming converters/igbinary to converters/pecl-igbinary to keep some consistency for pecl modules
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-17 11:50:03 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-17 11:50:03 UTC
Maintainer of converters/igbinary,

Please note that PR ports/187656 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/187656

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Bartek Rutkowski freebsd_committer freebsd_triage 2014-06-05 10:17:39 UTC
Created attachment 143398 [details]
converters-igbinary.diff
Comment 4 Bartek Rutkowski freebsd_committer freebsd_triage 2014-06-05 10:17:58 UTC
- Change the package name by adding PKGNAMESUFFIX in line with other similar ports
- Pet portlint

The build log against the attached diff file:

http://pd.valinor.palantiri.org:8080/latest-per-pkg/pecl-igbinary/1.1.1/
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-06-05 10:37:05 UTC
A commit references this bug:

Author: marino
Date: Thu Jun  5 10:36:17 UTC 2014
New revision: 356625
URL: http://svnweb.freebsd.org/changeset/ports/356625

Log:
  converters/igbinary: Add pecl- prefix for consistency

  While here, update the WWW link.

  PR:		ports/187656
  Submitted by:	daniel
  Tested by:	robak
  approved by:	maintainer timeout (3 months)

Changes:
  head/converters/igbinary/Makefile
  head/converters/igbinary/pkg-descr
Comment 6 John Marino freebsd_committer freebsd_triage 2014-06-05 10:45:41 UTC
committed as suggested, thanks!