Bug 188010

Summary:

madt_parse_nmi() checking incorrect flag

Product:

Base System

Reporter:

Takuya ASADA <syuu>

Component:

amd64

Assignee:

freebsd-amd64 (Nobody) <amd64>

Status:

Closed FIXED

Severity:

Affects Only Me

Priority:

Normal

Version:

Unspecified

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
file.diff	none

Description Takuya ASADA freebsd_committer

2014-03-27 05:40:00 UTC

madt_parse_nmi() checks ACPI_MADT_TRIGGER_CONFORMS before calling ioapic_set_polarity(), but it should check ACPI_MADT_POLARITY_CONFORMS instead.
I suppose this is typo.

Fix: Patch attached with submission follows:
How-To-Repeat: I haven't get any problem from this bug

Comment 1 dfilter service freebsd_committer

2014-03-27 06:08:09 UTC

Author: takawata
Date: Thu Mar 27 06:08:07 2014
New Revision: 263794
URL: http://svnweb.freebsd.org/changeset/base/263794

Log:
  To check polarity, check ACPI_MADT_POLARITY_CONFORMS, instead of ACPI_MADT_TRIGGER_CONFORMS.
  
  PR:amd64/188010
  Submitted by: syuu

Modified:
  head/sys/x86/acpica/madt.c

Modified: head/sys/x86/acpica/madt.c
==============================================================================
--- head/sys/x86/acpica/madt.c	Thu Mar 27 04:30:07 2014	(r263793)
+++ head/sys/x86/acpica/madt.c	Thu Mar 27 06:08:07 2014	(r263794)
@@ -492,7 +492,7 @@ madt_parse_nmi(ACPI_MADT_NMI_SOURCE *nmi
 	if (!(nmi->IntiFlags & ACPI_MADT_TRIGGER_CONFORMS))
 		ioapic_set_triggermode(ioapic, pin,
 		    interrupt_trigger(nmi->IntiFlags, 0));
-	if (!(nmi->IntiFlags & ACPI_MADT_TRIGGER_CONFORMS))
+	if (!(nmi->IntiFlags & ACPI_MADT_POLARITY_CONFORMS))
 		ioapic_set_polarity(ioapic, pin,
 		    interrupt_polarity(nmi->IntiFlags, 0));
 }
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"

Comment 2 Takanori Watanabe freebsd_committer

2014-03-27 06:08:55 UTC

State Changed
From-To: open->closed

Committed, thanks.