Bug 188020

Summary: net/isc-dhcp42-server port install/script issue
Product: Ports & Packages Reporter: Nick <decrofn>
Component: Individual Port(s)Assignee: Ryan Steinmetz <zi>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
isc-dhcp-server.diff none

Description Nick 2014-03-27 23:50:00 UTC 
When I install net/isc-dhcp42-server with PARANOIA support this creates /usr/local/etc/rc.d/isc-dhcpd which contains %%PARANOIA%% inside this causes warnings on star/restart

/usr/local/etc/rc.d/isc-dhcpd restart
/usr/local/etc/rc.d/isc-dhcpd: WARNING: $paranoia is not set properly - see rc.conf(5).
/usr/local/etc/rc.d/isc-dhcpd: WARNING: $dhcpd_chuser_enable is not set properly - see rc.conf(5).
/usr/local/etc/rc.d/isc-dhcpd: WARNING: $paranoia is not set properly - see rc.conf(5).
/usr/local/etc/rc.d/isc-dhcpd: WARNING: $paranoia is not set properly - see rc.conf(5).
/usr/local/etc/rc.d/isc-dhcpd: WARNING: $paranoia is not set properly - see rc.conf(5).
/usr/local/etc/rc.d/isc-dhcpd: WARNING: $dhcpd_chuser_enable is not set properly - see rc.conf(5).
/usr/local/etc/rc.d/isc-dhcpd: WARNING: $paranoia is not set properly - see rc.conf(5).
/usr/local/etc/rc.d/isc-dhcpd: WARNING: $paranoia is not set properly - see rc.conf(5).
/usr/local/etc/rc.d/isc-dhcpd: WARNING: $paranoia is not set properly - see rc.conf(5).

no matter of the rc.conf content which in my case is

dhcpd_enable="YES"
dhcpd_ifaces="LAN"
dhcpd_flags="-q"                           # command option(s)
dhcpd_conf="/usr/local/etc/dhcpd.conf"      # configuration file
dhcpd_withumask="022"
dhcpd_chuser_enable="YES"            # runs w/o privileges?
dhcpd_withuser="dhcpd"              # user name to run as
dhcpd_withgroup="dhcpd"             # group name to run as
dhcpd_chroot_enable="YES"           # runs chrooted?
dhcpd_devfs_enable="YES"            # use devfs if available?
dhcpd_rootdir="/var/db/dhcpd"       # directory to run in
#dhcpd_includedir=""       # directory with config-files to include

here is more detailed description https://forums.freebsd.org/viewtopic.php?f=5&t=45677&p=255277#p255277

Fix: 

replace %%PARANOIA%% to yes inside /usr/local/etc/rc.d/isc-dhcpd
How-To-Repeat: install net/isc-dhcp42-server and view /usr/local/etc/rc.d/isc-dhcpd
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-28 05:42:48 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->zi

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Jason Unovitch freebsd_committer freebsd_triage 2014-03-29 20:36:47 UTC 
I came across this issue as well while testing isc-dhcp43-server. This 
affects isc-dhcp41-server, isc-dhcp42-server, and isc-dhcp43-server.   
It looks like removing PARANOIA from the SUB_LIST when staging support 
was added was the cause.  Patch attached to add back the following lines.

SUB_LIST+=      PARANOIA=yes
.else
SUB_LIST+=      PARANOIA=no
Comment 3 dfilter service freebsd_committer freebsd_triage 2014-03-30 14:31:49 UTC 
Author: zi
Date: Sun Mar 30 13:31:45 2014
New Revision: 349617
URL: http://svnweb.freebsd.org/changeset/ports/349617
QAT: https://qat.redports.org/buildarchive/r349617/

Log:
  - Unbreak botched STAGE conversion
  - Bump PORTREVISION
  
  PR:		ports/188020
  Submitted by:	Nick <decrofn@gmail.com>, Jason Unovitch <oneshotuno@yahoo.com>

Modified:
  head/net/isc-dhcp41-server/Makefile
  head/net/isc-dhcp42-server/Makefile
  head/net/isc-dhcp43-server/Makefile

Modified: head/net/isc-dhcp41-server/Makefile
==============================================================================
--- head/net/isc-dhcp41-server/Makefile	Sun Mar 30 12:50:11 2014	(r349616)
+++ head/net/isc-dhcp41-server/Makefile	Sun Mar 30 13:31:45 2014	(r349617)
@@ -17,7 +17,7 @@ COMMENT?=	The ISC Dynamic Host Configura
 LICENSE=	ISCL
 
 PATCHLEVEL=	R7
-PORTREVISION_SERVER=	7
+PORTREVISION_SERVER=	8
 PORTREVISION_CLIENT=	2
 PORTREVISION_RELAY=	5
 
@@ -119,6 +119,9 @@ CONFIGURE_ENV+=	LIBS="-lssl"
 
 .if ${PORT_OPTIONS:MPARANOIA}
 CONFIGURE_ARGS+=	--enable-paranoia --enable-early-chroot
+SUB_LIST+=		PARANOIA="yes"
+.else
+SUB_LIST+=		PARANOIA="no"
 .endif
 
 .if ${PORT_OPTIONS:MIPV6}

Modified: head/net/isc-dhcp42-server/Makefile
==============================================================================
--- head/net/isc-dhcp42-server/Makefile	Sun Mar 30 12:50:11 2014	(r349616)
+++ head/net/isc-dhcp42-server/Makefile	Sun Mar 30 13:31:45 2014	(r349617)
@@ -19,7 +19,7 @@ LICENSE=	ISCL
 USES=		gmake
 
 PATCHLEVEL=	P1
-PORTREVISION_SERVER=	0
+PORTREVISION_SERVER=	1
 PORTREVISION_CLIENT=	0
 PORTREVISION_RELAY=	0
 
@@ -91,6 +91,9 @@ PKGMESSAGE_SUB=	PREFIX="${PREFIX}" MAN1P
 
 .if ${PORT_OPTIONS:MPARANOIA}
 CONFIGURE_ARGS+=--enable-paranoia --enable-early-chroot
+SUB_LIST+=	PARANOIA="yes"
+.else
+SUB_LIST+=	PARANOIA="no"
 .endif
 
 .if ${PORT_OPTIONS:MLDAP}

Modified: head/net/isc-dhcp43-server/Makefile
==============================================================================
--- head/net/isc-dhcp43-server/Makefile	Sun Mar 30 12:50:11 2014	(r349616)
+++ head/net/isc-dhcp43-server/Makefile	Sun Mar 30 13:31:45 2014	(r349617)
@@ -19,7 +19,7 @@ LICENSE=	ISCL
 USES=		gmake
 
 #PATCHLEVEL=	P1
-PORTREVISION_SERVER=	0
+PORTREVISION_SERVER=	1
 PORTREVISION_CLIENT=	0
 PORTREVISION_RELAY=	0
 
@@ -91,6 +91,9 @@ PKGMESSAGE_SUB=	PREFIX="${PREFIX}" MAN1P
 
 .if ${PORT_OPTIONS:MPARANOIA}
 CONFIGURE_ARGS+=--enable-paranoia --enable-early-chroot
+SUB_LIST+=	PARANOIA="yes"
+.else
+SUB_LIST+=	PARANOIA="no"
 .endif
 
 .if ${PORT_OPTIONS:MLDAP}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Ryan Steinmetz freebsd_committer freebsd_triage 2014-03-30 14:31:57 UTC 
State Changed
From-To: open->closed

Committed. Thanks!