Bug 188203

Summary: [PATCH] x11/xcb app defaults file is not built correctly
Product: Ports & Packages Reporter: Callum Gibson <callum>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: marino
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Callum Gibson 2014-04-02 22:40:00 UTC 
The app-defaults file for xcb is not built correctly as a consequence of
switch to clang and replacement of gcc's cpp. tradcpp is more strict about
the order of the parameters and the filename must be last on the command line
otherwise a zero length file is created.

Fix: Move filename to end of cpp command in make rule (see patch).




Xcb.ad:        Xcb.ad.base
-       $(CPP) -P Xcb.ad.base $(GUI) > $@    # -P removes line directives.
+       $(CPP) -P $(GUI) Xcb.ad.base > $@    # -P removes line directives.

 InstallAppDefaults(Xcb)--iXEe17usCOJxEoWW9Geu169gVtGw4gkCEnbVpwCHkoDpVaBL
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Imakefile.orig      2014-04-03 08:18:34.528207895 +1100
+++ Imakefile   2014-04-03 06:40:39.413006135 +1100
@@ -20,6 +20,6 @@
 ComplexProgramTarget(xcb)
How-To-Repeat: Install and run x11/xcb port. Note it doesn't display properly.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-07-22 18:49:11 UTC 
fyi: no port maintainer.

Bumping this with "ready" so it catches someone's eye
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-07-27 08:52:20 UTC 
A commit references this bug:

Author: marino
Date: Sun Jul 27 08:51:37 UTC 2014
New revision: 363029
URL: http://svnweb.freebsd.org/changeset/ports/363029

Log:
  x11/xcb: Fix incorrectly built app-defaults file

  The app-defaults file for xcb was not built correctly as a consequence of
  the switch to clang and replacement of gcc's cpp to tradcpp which is more
  strict about the order of the parameters.  The filename must be last on
  the command line otherwise a zero-length file is created.

  Fixed by moving the filename parameter to the end of the cpp command

  PR:		188203
  Submitted by:	callum (omma.gibson.athome)

Changes:
  head/x11/xcb/Makefile
  head/x11/xcb/files/
  head/x11/xcb/files/patch-Imakefile
Comment 3 John Marino freebsd_committer freebsd_triage 2014-07-27 08:53:02 UTC 
Thanks!