Bug 188204

Summary: [maintainer update] databases/cppdb
Product: Ports & Packages Reporter: Mamadou Babaei <info>
Component: Individual Port(s)Assignee: Alex Kozlov <ak>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Mamadou Babaei 2014-04-02 22:50:00 UTC 
1. Fixed a typo in LIB_DEPENDS (libodbc.so which was written libodbc.do)
2. Using USES+= tar:bzip2 instead of deprecated USE_BZIP2
3. Using tabs instead of space, so portlint won't complain anymore

Fix: Patch attached with submission follows:
Comment 1 Alex Kozlov freebsd_committer freebsd_triage 2014-04-06 10:57:55 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ak

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-04-06 10:58:12 UTC 
Author: ak
Date: Sun Apr  6 09:58:09 2014
New Revision: 350344
URL: http://svnweb.freebsd.org/changeset/ports/350344
QAT: https://qat.redports.org/buildarchive/r350344/

Log:
  - Fix typo in LIB_DEPENDS
  - Use tar:bz2
  - Convert spaces to tabs
  
  PR:	ports/188204
  Submitted by:	"Mohammad S. Babaei" <info@babaei.net> (maintainer)

Modified:
  head/databases/cppdb/Makefile

Modified: head/databases/cppdb/Makefile
==============================================================================
--- head/databases/cppdb/Makefile	Sun Apr  6 09:39:24 2014	(r350343)
+++ head/databases/cppdb/Makefile	Sun Apr  6 09:58:09 2014	(r350344)
@@ -1,105 +1,103 @@
 # Created by: Mohammad S. Babaei <info@babaei.net>
 # $FreeBSD$
 
-PORTNAME=       cppdb
-PORTVERSION=    0.3.1
-CATEGORIES=     databases
-MASTER_SITES=   SF/cppcms/${PORTNAME}/${PORTVERSION}
-
-MAINTAINER= info@babaei.net
-COMMENT=    Platform and database independent SQL connectivity library
-
-LICENSE=        BSL MIT
-LICENSE_COMB=   dual
-LICENSE_FILE=   ${WRKSRC}/copyright.txt
-
-NO_OPTIONS_SORT=	    yes
-OPTIONS_SINGLE=         SQLITE3 PGSQL MYSQL ODBC
-OPTIONS_SINGLE_MYSQL=   MYSQL_DISABLE MYSQL_INTERNAL MYSQL_MODULE
-OPTIONS_SINGLE_ODBC=    ODBC_DISABLE ODBC_INTERNAL ODBC_MODULE
-OPTIONS_SINGLE_PGSQL=      PGSQL_DISABLE PGSQL_INTERNAL PGSQL_MODULE
-OPTIONS_SINGLE_SQLITE3=  SQLITE3_DISABLE SQLITE3_INTERNAL SQLITE3_MODULE
-
-OPTIONS_DEFAULT=   MYSQL_DISABLE ODBC_DISABLE PGSQL_DISABLE SQLITE3_MODULE
-
-MYSQL_DESC=             MySQL Backend
-MYSQL_DISABLE_DESC=     Disable MySQL backend
-MYSQL_INTERNAL_DESC=    Link MySQL backend into CppDB
-MYSQL_MODULE_DESC=      Build MySQL backend as a CppDB module
-ODBC_DESC=              ODBC Backend
-ODBC_DISABLE_DESC=      Disable ODBC backend
-ODBC_INTERNAL_DESC=     Link ODBC backend into CppDB
-ODBC_MODULE_DESC=       Build ODBC backend as a CppDB module
-PGSQL_DESC=             PostgreSQL Backend
-PGSQL_DISABLE_DESC=     Disable PostgreSQL backend
-PGSQL_INTERNAL_DESC=    Link PostgreSQL backend into CppDB
-PGSQL_MODULE_DESC=      Build PostgreSQL backend as a CppDB module
-SQLITE3_DESC=           SQLite 3 Backend
-SQLITE3_DISABLE_DESC=   Disable SQLite 3 backend
-SQLITE3_INTERNAL_DESC=  Link SQLite 3 backend into CppDB
-SQLITE3_MODULE_DESC=    Build SQLite 3 backend as a CppDB module
-
-USE_BZIP2=      yes
-USE_LDCONFIG=   yes
-USES=           cmake
-MAKE_JOBS_SAFE= yes
+PORTNAME=	cppdb
+PORTVERSION=	0.3.1
+CATEGORIES=	databases
+MASTER_SITES=	SF/cppcms/${PORTNAME}/${PORTVERSION}
+
+MAINTAINER=	info@babaei.net
+COMMENT=	Platform and database independent SQL connectivity library
+
+LICENSE=	BSL MIT
+LICENSE_COMB=	dual
+LICENSE_FILE=	${WRKSRC}/copyright.txt
+
+NO_OPTIONS_SORT=	yes
+OPTIONS_SINGLE=		SQLITE3 PGSQL MYSQL ODBC
+OPTIONS_SINGLE_MYSQL=	MYSQL_DISABLE MYSQL_INTERNAL MYSQL_MODULE
+OPTIONS_SINGLE_ODBC=	ODBC_DISABLE ODBC_INTERNAL ODBC_MODULE
+OPTIONS_SINGLE_PGSQL=	PGSQL_DISABLE PGSQL_INTERNAL PGSQL_MODULE
+OPTIONS_SINGLE_SQLITE3=	SQLITE3_DISABLE SQLITE3_INTERNAL SQLITE3_MODULE
+
+OPTIONS_DEFAULT=	MYSQL_DISABLE ODBC_DISABLE PGSQL_DISABLE SQLITE3_MODULE
+
+MYSQL_DESC=		MySQL Backend
+MYSQL_DISABLE_DESC=	Disable MySQL backend
+MYSQL_INTERNAL_DESC=	Link MySQL backend into CppDB
+MYSQL_MODULE_DESC=	Build MySQL backend as a CppDB module
+ODBC_DESC=		ODBC Backend
+ODBC_DISABLE_DESC=	Disable ODBC backend
+ODBC_INTERNAL_DESC=	Link ODBC backend into CppDB
+ODBC_MODULE_DESC=	Build ODBC backend as a CppDB module
+PGSQL_DESC=		PostgreSQL Backend
+PGSQL_DISABLE_DESC=	Disable PostgreSQL backend
+PGSQL_INTERNAL_DESC=	Link PostgreSQL backend into CppDB
+PGSQL_MODULE_DESC=	Build PostgreSQL backend as a CppDB module
+SQLITE3_DESC=		SQLite 3 Backend
+SQLITE3_DISABLE_DESC=	Disable SQLite 3 backend
+SQLITE3_INTERNAL_DESC=	Link SQLite 3 backend into CppDB
+SQLITE3_MODULE_DESC=	Build SQLite 3 backend as a CppDB module
+
+USE_LDCONFIG=	yes
+USES=		cmake tar:bzip2
 
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MMYSQL_DISABLE}
-CMAKE_ARGS+=    -DDISABLE_MYSQL:BOOL=ON
-PLIST_SUB+=     MYSQL="@comment "
+CMAKE_ARGS+=	-DDISABLE_MYSQL:BOOL=ON
+PLIST_SUB+=	MYSQL="@comment "
 .else
-USE_MYSQL=      yes
-CMAKE_ARGS+=    -DDISABLE_MYSQL:BOOL=OFF
+USE_MYSQL=	yes
+CMAKE_ARGS+=	-DDISABLE_MYSQL:BOOL=OFF
 .if ${PORT_OPTIONS:MMYSQL_INTERNAL}
-CMAKE_ARGS+=    -DMYSQL_BACKEND_INTERNAL:BOOL=ON
-.else
-CMAKE_ARGS+=    -DMYSQL_BACKEND_INTERNAL:BOOL=OFF
+CMAKE_ARGS+=	-DMYSQL_BACKEND_INTERNAL:BOOL=ON
+.elif ${PORT_OPTIONS:MMYSQL_MODULE}
+CMAKE_ARGS+=	-DMYSQL_BACKEND_INTERNAL:BOOL=OFF
 .endif
-PLIST_SUB+=     MYSQL=""
+PLIST_SUB+=	MYSQL=""
 .endif
 
 .if ${PORT_OPTIONS:MODBC_DISABLE}
-CMAKE_ARGS+=    -DDISABLE_ODBC:BOOL=ON
-PLIST_SUB+=     ODBC="@comment "
+CMAKE_ARGS+=	-DDISABLE_ODBC:BOOL=ON
+PLIST_SUB+=	ODBC="@comment "
 .else
-LIB_DEPENDS+=   libodbc.do:${PORTSDIR}/databases/unixODBC
-CMAKE_ARGS+=    -DDISABLE_ODBC:BOOL=OFF
+LIB_DEPENDS+=	libodbc.so:${PORTSDIR}/databases/unixODBC
+CMAKE_ARGS+=	-DDISABLE_ODBC:BOOL=OFF
 .if ${PORT_OPTIONS:MODBC_INTERNAL}
-CMAKE_ARGS+=    -DODBC_BACKEND_INTERNAL:BOOL=ON
-.else
-CMAKE_ARGS+=    -DODBC_BACKEND_INTERNAL:BOOL=OFF
+CMAKE_ARGS+=	-DODBC_BACKEND_INTERNAL:BOOL=ON
+.elif ${PORT_OPTIONS:MODBC_MODULE}
+CMAKE_ARGS+=	-DODBC_BACKEND_INTERNAL:BOOL=OFF
 .endif
-PLIST_SUB+=     ODBC=""
+PLIST_SUB+=	ODBC=""
 .endif
 
 .if ${PORT_OPTIONS:MPGSQL_DISABLE}
-CMAKE_ARGS+=    -DDISABLE_PQ:BOOL=ON
-PLIST_SUB+=     PGSQL="@comment "
+CMAKE_ARGS+=	-DDISABLE_PQ:BOOL=ON
+PLIST_SUB+=	PGSQL="@comment "
 .else
-USE_PGSQL=      yes
-CMAKE_ARGS+=    -DDISABLE_PQ:BOOL=OFF
+USE_PGSQL=	yes
+CMAKE_ARGS+=	-DDISABLE_PQ:BOOL=OFF
 .if ${PORT_OPTIONS:MPGSQL_INTERNAL}
-CMAKE_ARGS+=    -DPQ_BACKEND_INTERNAL:BOOL=ON
-.else
-CMAKE_ARGS+=    -DPQ_BACKEND_INTERNAL:BOOL=OFF
+CMAKE_ARGS+=	-DPQ_BACKEND_INTERNAL:BOOL=ON
+.elif ${PORT_OPTIONS:MPGSQL_MODULE}
+CMAKE_ARGS+=	-DPQ_BACKEND_INTERNAL:BOOL=OFF
 .endif
-PLIST_SUB+=     PGSQL=""
+PLIST_SUB+=	PGSQL=""
 .endif
 
 .if ${PORT_OPTIONS:MSQLITE3_DISABLE}
-CMAKE_ARGS+=    -DDISABLE_SQLITE:BOOL=ON
-PLIST_SUB+=     SQLITE3="@comment "
+CMAKE_ARGS+=	-DDISABLE_SQLITE:BOOL=ON
+PLIST_SUB+=	SQLITE3="@comment "
 .else
-USE_SQLITE=     3
-CMAKE_ARGS+=    -DDISABLE_SQLITE:BOOL=OFF
+USE_SQLITE=	3
+CMAKE_ARGS+=	-DDISABLE_SQLITE:BOOL=OFF
 .if ${PORT_OPTIONS:MSQLITE3_INTERNAL}
-CMAKE_ARGS+=    -DSQLITE_BACKEND_INTERNAL:BOOL=ON
-.else
-CMAKE_ARGS+=    -DSQLITE_BACKEND_INTERNAL:BOOL=OFF
+CMAKE_ARGS+=	-DSQLITE_BACKEND_INTERNAL:BOOL=ON
+.elif ${PORT_OPTIONS:MSQLITE3_MODULE}
+CMAKE_ARGS+=	-DSQLITE_BACKEND_INTERNAL:BOOL=OFF
 .endif
-PLIST_SUB+=     SQLITE3=""
+PLIST_SUB+=	SQLITE3=""
 .endif
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Alex Kozlov freebsd_committer freebsd_triage 2014-04-06 10:58:22 UTC 
State Changed
From-To: open->closed

Committed. Thanks!