Bug 188285

Summary: [PATCH] lang/php5: Unneccesary ZTS/threaded warning WITH_ZTS
Product: Ports & Packages Reporter: Bernard Spil <brnrd>
Component: Individual Port(s)Assignee: Alex Dupre <ale>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Bernard Spil freebsd_committer freebsd_triage 2014-04-05 10:50:00 UTC
When building mod_php55 there was an unneccesary warning
!!! If you have a threaded Apache, you must build ${PHP_PORT} with ZTS support to enable thread-safety in extensions !!!
when make is run with (non-default) option ZTS enabled

Fix: Add conditional block around the warning that checks the ZTS option (see patch)

Patch attached with submission follows:
How-To-Repeat: # make showconfig
===> The following configuration options are available for mod_php55-5.5.11:
     AP2FILTER=off: Use Apache 2.x filter interface (experimental)
     DEBUG=off: Enable debug
     DTRACE=off: Enable DTrace support
     IPV6=on: Enable ipv6 support
     MAILHEAD=off: Enable mail header patch
     LINKTHR=on: Link thread lib (for threaded extensions)
     ZTS=on: Force Zend Thread Safety (ZTS) build
===> Use 'make config' to modify these settings
# # make
/!\ WARNING /!\
!!! If you have a threaded Apache, you must build lang/php55 with ZTS support to enable thread-safety in extensions !!!
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-05 11:42:44 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ale

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Alex Dupre freebsd_committer freebsd_triage 2014-04-05 12:44:26 UTC
State Changed
From-To: open->closed

You should re-read carefully the warning :-)