Bug 188377

Summary: audio/xmms2
Product: Ports & Packages Reporter: Volodymyr Kostyrko <arcade>
Component: Individual Port(s)Assignee: Guido Falsi <madpilot>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
options
none
xmms2.log
none
pkg.info none

Description Volodymyr Kostyrko 2014-04-08 15:00:00 UTC
[164/217] c: src/plugins/mp4/mp4ff/mp4atom.c -> _build_/src/plugins/mp4/mp4ff/mp4atom.c.1.o
./src/plugins/modplug/modplug.c:12:10: fatal error: 'modplug.h' file not found
#include <modplug.h>
         ^
1 error generated

This one should be:

#include <libmodplug/modplug.h>
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-08 15:00:05 UTC
Responsible Changed
From-To: freebsd-ports-bugs->madpilot

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2014-04-09 09:19:59 UTC
Hi,

Can you please send me the full log of the failed build?

I'd also like to have the options file (should be the file
/var/db/ports/audio_xmms2/options) and the output of "pkg info" (or
"pkg_info" if using the old package tools) of the affected system.

Thanks in advance.

-- 
Guido Falsi <madpilot@FreeBSD.org>
Comment 3 Volodymyr Kostyrko 2014-04-09 10:02:56 UTC
09.04.2014 11:19, Guido Falsi wrote:
> Hi,
>
> Can you please send me the full log of the failed build?
>
> I'd also like to have the options file (should be the file
> /var/db/ports/audio_xmms2/options) and the output of "pkg info" (or
> "pkg_info" if using the old package tools) of the affected system.
>
> Thanks in advance.

NP, attaching.

PS: I found that I actually have no /var/db/ports/audio_xmms2 directory 
present, only /var/db/ports/xmms2. `make config` with saving results 
created the required file but error is the same.

-- 
Sphinx of black quartz, judge my vow.
Comment 4 dfilter service freebsd_committer freebsd_triage 2014-04-09 16:07:48 UTC
Author: madpilot
Date: Wed Apr  9 15:07:44 2014
New Revision: 350720
URL: http://svnweb.freebsd.org/changeset/ports/350720
QAT: https://qat.redports.org/buildarchive/r350720/

Log:
  - Fix build when MODPLUG option is enabled (disabled by default)
  
  PR:		ports/188377
  Submitted by:	Volodymyr Kostyrko <arcade@b1t.name>

Added:
  head/audio/xmms2/files/patch-src-plugins-modplug-modplug.c   (contents, props changed)

Added: head/audio/xmms2/files/patch-src-plugins-modplug-modplug.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/audio/xmms2/files/patch-src-plugins-modplug-modplug.c	Wed Apr  9 15:07:44 2014	(r350720)
@@ -0,0 +1,11 @@
+--- src/plugins/modplug/modplug.c.orig	2011-10-20 21:26:08.000000000 +0200
++++ src/plugins/modplug/modplug.c	2014-04-09 15:05:29.232679291 +0200
+@@ -9,7 +9,7 @@
+ #include "xmms/xmms_sample.h"
+ #include "xmms/xmms_medialib.h"
+ #include "xmms/xmms_log.h"
+-#include <modplug.h>
++#include <libmodplug/modplug.h>
+ 
+ #include <glib.h>
+ #include <string.h>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Guido Falsi freebsd_committer freebsd_triage 2014-04-09 16:08:20 UTC
Thanks for the report, I committed a fix in r350720.

-- 
Guido Falsi <madpilot@FreeBSD.org>
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2014-04-09 16:09:05 UTC
State Changed
From-To: open->closed

Fix committed. Thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2014-04-13 11:20:19 UTC
Author: madpilot
Date: Sun Apr 13 10:20:15 2014
New Revision: 351198
URL: http://svnweb.freebsd.org/changeset/ports/351198
QAT: https://qat.redports.org/buildarchive/r351198/

Log:
  MFH: r350720
  
  - Fix build when MODPLUG option is enabled (disabled by default)
  
  PR:		ports/188377
  Submitted by:	Volodymyr Kostyrko <arcade@b1t.name>
  
  Approved by:	portmgr (bapt)

Added:
  branches/2014Q2/audio/xmms2/files/patch-src-plugins-modplug-modplug.c
     - copied unchanged from r350720, head/audio/xmms2/files/patch-src-plugins-modplug-modplug.c
Modified:
Directory Properties:
  branches/2014Q2/   (props changed)

Copied: branches/2014Q2/audio/xmms2/files/patch-src-plugins-modplug-modplug.c (from r350720, head/audio/xmms2/files/patch-src-plugins-modplug-modplug.c)
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ branches/2014Q2/audio/xmms2/files/patch-src-plugins-modplug-modplug.c	Sun Apr 13 10:20:15 2014	(r351198, copy of r350720, head/audio/xmms2/files/patch-src-plugins-modplug-modplug.c)
@@ -0,0 +1,11 @@
+--- src/plugins/modplug/modplug.c.orig	2011-10-20 21:26:08.000000000 +0200
++++ src/plugins/modplug/modplug.c	2014-04-09 15:05:29.232679291 +0200
+@@ -9,7 +9,7 @@
+ #include "xmms/xmms_sample.h"
+ #include "xmms/xmms_medialib.h"
+ #include "xmms/xmms_log.h"
+-#include <modplug.h>
++#include <libmodplug/modplug.h>
+ 
+ #include <glib.h>
+ #include <string.h>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"