Bug 188439

Summary: broken startup script in: dns/bind99
Product: Ports & Packages Reporter: Oliver Lehmann <oliver>
Component: Individual Port(s)Assignee: Mathieu Arnold <mat>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Oliver Lehmann freebsd_committer 2014-04-10 20:00:00 UTC
	a)
	"ldconfig" is missing as dependency in the start script
	On system bootup, named cannot be started, because libxml2.so.5 cannot
	be found to execute the namedconf and named command. Adding "ldconfig"
	to the dependency of the rc-script fixes this
	b)
	The pid-file dtection is broken. Just put "pid-file /var/run/named.pid"
	in your named.conf and the startscript will create a directory(!) with
	that name rendering named unable to start its configured pid file at the
	same location...
Comment 1 Edwin Groothuis freebsd_committer 2014-04-10 20:00:05 UTC
Responsible Changed
From-To: freebsd-ports-bugs->mat

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2014-04-10 21:43:54 UTC
Author: mat
Date: Thu Apr 10 20:43:50 2014
New Revision: 350848
URL: http://svnweb.freebsd.org/changeset/ports/350848
QAT: https://qat.redports.org/buildarchive/r350848/

Log:
  Two changes to the RC script
  - Add a dependency on ldconfig
  - Allow people to change the pidfile
  
  PR:		188439
  Submitted by:	Oliver Lehmann
  Sponsored by:	Absolight

Modified:
  head/dns/bind910/Makefile
  head/dns/bind910/files/named.in
  head/dns/bind98/Makefile
  head/dns/bind98/files/named.in
  head/dns/bind99/Makefile
  head/dns/bind99/files/named.in

Modified: head/dns/bind910/Makefile
==============================================================================
--- head/dns/bind910/Makefile	Thu Apr 10 20:20:35 2014	(r350847)
+++ head/dns/bind910/Makefile	Thu Apr 10 20:43:50 2014	(r350848)
@@ -2,6 +2,7 @@
 
 PORTNAME=	bind
 PORTVERSION=	9.10.0rc1
+PORTREVISION=	1
 CATEGORIES=	dns net ipv6
 MASTER_SITES=	${MASTER_SITE_ISC}
 MASTER_SITE_SUBDIR=	bind9/${ISCVERSION}

Modified: head/dns/bind910/files/named.in
==============================================================================
--- head/dns/bind910/files/named.in	Thu Apr 10 20:20:35 2014	(r350847)
+++ head/dns/bind910/files/named.in	Thu Apr 10 20:43:50 2014	(r350848)
@@ -4,7 +4,7 @@
 #
 
 # PROVIDE: named
-# REQUIRE: FILESYSTEMS defaultroute
+# REQUIRE: FILESYSTEMS defaultroute ldconfig
 # BEFORE: NETWORKING
 # KEYWORD: shutdown
 
@@ -92,9 +92,9 @@ named_prestart()
 		warn 'named_pidfile: now determined from the conf file'
 	fi
 
-	echo ${pidfile%/pid}
-	if [ ! -d ${pidfile%/pid} ]; then
-		install -d -o ${named_uid} -g ${named_uid} ${pidfile%/pid}
+	piddir=`/usr/bin/dirname ${pidfile}`
+	if [ ! -d ${piddir} ]; then
+		install -d -o ${named_uid} -g ${named_uid} ${piddir}
 	fi
 
 	command_args="-u ${named_uid:=root} -c $named_conf $command_args"

Modified: head/dns/bind98/Makefile
==============================================================================
--- head/dns/bind98/Makefile	Thu Apr 10 20:20:35 2014	(r350847)
+++ head/dns/bind98/Makefile	Thu Apr 10 20:43:50 2014	(r350848)
@@ -2,7 +2,7 @@
 
 PORTNAME=	bind
 PORTVERSION=	9.8.7
-PORTREVISION=	7
+PORTREVISION=	8
 CATEGORIES=	dns net ipv6
 MASTER_SITES=	${MASTER_SITE_ISC}
 MASTER_SITE_SUBDIR=	bind9/${ISCVERSION}

Modified: head/dns/bind98/files/named.in
==============================================================================
--- head/dns/bind98/files/named.in	Thu Apr 10 20:20:35 2014	(r350847)
+++ head/dns/bind98/files/named.in	Thu Apr 10 20:43:50 2014	(r350848)
@@ -4,7 +4,7 @@
 #
 
 # PROVIDE: named
-# REQUIRE: FILESYSTEMS defaultroute
+# REQUIRE: FILESYSTEMS defaultroute ldconfig
 # BEFORE: NETWORKING
 # KEYWORD: shutdown
 
@@ -91,9 +91,9 @@ named_prestart()
 		warn 'named_pidfile: now determined from the conf file'
 	fi
 
-	echo ${pidfile%/pid}
-	if [ ! -d ${pidfile%/pid} ]; then
-		install -d -o ${named_uid} -g ${named_uid} ${pidfile%/pid}
+	piddir=`/usr/bin/dirname ${pidfile}`
+	if [ ! -d ${piddir} ]; then
+		install -d -o ${named_uid} -g ${named_uid} ${piddir}
 	fi
 
 	command_args="-u ${named_uid:=root} -c $named_conf $command_args"

Modified: head/dns/bind99/Makefile
==============================================================================
--- head/dns/bind99/Makefile	Thu Apr 10 20:20:35 2014	(r350847)
+++ head/dns/bind99/Makefile	Thu Apr 10 20:43:50 2014	(r350848)
@@ -2,7 +2,7 @@
 
 PORTNAME=	bind
 PORTVERSION=	9.9.5
-PORTREVISION=	9
+PORTREVISION=	10
 CATEGORIES=	dns net ipv6
 MASTER_SITES=	${MASTER_SITE_ISC}
 MASTER_SITE_SUBDIR=	bind9/${ISCVERSION}

Modified: head/dns/bind99/files/named.in
==============================================================================
--- head/dns/bind99/files/named.in	Thu Apr 10 20:20:35 2014	(r350847)
+++ head/dns/bind99/files/named.in	Thu Apr 10 20:43:50 2014	(r350848)
@@ -4,7 +4,7 @@
 #
 
 # PROVIDE: named
-# REQUIRE: FILESYSTEMS defaultroute
+# REQUIRE: FILESYSTEMS defaultroute ldconfig
 # BEFORE: NETWORKING
 # KEYWORD: shutdown
 
@@ -91,9 +91,9 @@ named_prestart()
 		warn 'named_pidfile: now determined from the conf file'
 	fi
 
-	echo ${pidfile%/pid}
-	if [ ! -d ${pidfile%/pid} ]; then
-		install -d -o ${named_uid} -g ${named_uid} ${pidfile%/pid}
+	piddir=`/usr/bin/dirname ${pidfile}`
+	if [ ! -d ${piddir} ]; then
+		install -d -o ${named_uid} -g ${named_uid} ${piddir}
 	fi
 
 	command_args="-u ${named_uid:=root} -c $named_conf $command_args"
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Mathieu Arnold freebsd_committer 2014-04-10 21:44:02 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 4 dfilter service freebsd_committer 2014-04-10 22:52:10 UTC
Author: mat
Date: Thu Apr 10 21:52:06 2014
New Revision: 350861
URL: http://svnweb.freebsd.org/changeset/ports/350861
QAT: https://qat.redports.org/buildarchive/r350861/

Log:
  MFH: r350848
  
  Two changes to the RC script
  - Add a dependency on ldconfig
  - Allow people to change the pidfile
  
  PR:		188439
  Submitted by:	Oliver Lehmann
  Sponsored by:	Absolight

Modified:
  branches/2014Q2/dns/bind98/Makefile
  branches/2014Q2/dns/bind98/files/named.in
  branches/2014Q2/dns/bind99/Makefile
  branches/2014Q2/dns/bind99/files/named.in
Directory Properties:
  branches/2014Q2/   (props changed)

Modified: branches/2014Q2/dns/bind98/Makefile
==============================================================================
--- branches/2014Q2/dns/bind98/Makefile	Thu Apr 10 21:48:42 2014	(r350860)
+++ branches/2014Q2/dns/bind98/Makefile	Thu Apr 10 21:52:06 2014	(r350861)
@@ -2,7 +2,7 @@
 
 PORTNAME=	bind
 PORTVERSION=	9.8.7
-PORTREVISION=	7
+PORTREVISION=	8
 CATEGORIES=	dns net ipv6
 MASTER_SITES=	${MASTER_SITE_ISC}
 MASTER_SITE_SUBDIR=	bind9/${ISCVERSION}

Modified: branches/2014Q2/dns/bind98/files/named.in
==============================================================================
--- branches/2014Q2/dns/bind98/files/named.in	Thu Apr 10 21:48:42 2014	(r350860)
+++ branches/2014Q2/dns/bind98/files/named.in	Thu Apr 10 21:52:06 2014	(r350861)
@@ -4,7 +4,7 @@
 #
 
 # PROVIDE: named
-# REQUIRE: FILESYSTEMS defaultroute
+# REQUIRE: FILESYSTEMS defaultroute ldconfig
 # BEFORE: NETWORKING
 # KEYWORD: shutdown
 
@@ -91,9 +91,9 @@ named_prestart()
 		warn 'named_pidfile: now determined from the conf file'
 	fi
 
-	echo ${pidfile%/pid}
-	if [ ! -d ${pidfile%/pid} ]; then
-		install -d -o ${named_uid} -g ${named_uid} ${pidfile%/pid}
+	piddir=`/usr/bin/dirname ${pidfile}`
+	if [ ! -d ${piddir} ]; then
+		install -d -o ${named_uid} -g ${named_uid} ${piddir}
 	fi
 
 	command_args="-u ${named_uid:=root} -c $named_conf $command_args"

Modified: branches/2014Q2/dns/bind99/Makefile
==============================================================================
--- branches/2014Q2/dns/bind99/Makefile	Thu Apr 10 21:48:42 2014	(r350860)
+++ branches/2014Q2/dns/bind99/Makefile	Thu Apr 10 21:52:06 2014	(r350861)
@@ -2,7 +2,7 @@
 
 PORTNAME=	bind
 PORTVERSION=	9.9.5
-PORTREVISION=	9
+PORTREVISION=	10
 CATEGORIES=	dns net ipv6
 MASTER_SITES=	${MASTER_SITE_ISC}
 MASTER_SITE_SUBDIR=	bind9/${ISCVERSION}

Modified: branches/2014Q2/dns/bind99/files/named.in
==============================================================================
--- branches/2014Q2/dns/bind99/files/named.in	Thu Apr 10 21:48:42 2014	(r350860)
+++ branches/2014Q2/dns/bind99/files/named.in	Thu Apr 10 21:52:06 2014	(r350861)
@@ -4,7 +4,7 @@
 #
 
 # PROVIDE: named
-# REQUIRE: FILESYSTEMS defaultroute
+# REQUIRE: FILESYSTEMS defaultroute ldconfig
 # BEFORE: NETWORKING
 # KEYWORD: shutdown
 
@@ -91,9 +91,9 @@ named_prestart()
 		warn 'named_pidfile: now determined from the conf file'
 	fi
 
-	echo ${pidfile%/pid}
-	if [ ! -d ${pidfile%/pid} ]; then
-		install -d -o ${named_uid} -g ${named_uid} ${pidfile%/pid}
+	piddir=`/usr/bin/dirname ${pidfile}`
+	if [ ! -d ${piddir} ]; then
+		install -d -o ${named_uid} -g ${named_uid} ${piddir}
 	fi
 
 	command_args="-u ${named_uid:=root} -c $named_conf $command_args"
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"